Hi Anuj, Thanks for your explanation. I've sent patch v2 out. Thanks, Arthur
On Wed, Jul 8, 2020 at 6:29 PM Mittal, Anuj <[email protected]> wrote: > On Tue, 2020-07-07 at 18:01 -0700, Arthur She wrote: > > Hi Anuj, > > Thanks for your review. > > I don't need to put "-Dchamelium=disabled" in the EXTRA_OEMESON. > > Because chamelium is disabled by default. > > Is it correct? > > Yes, since it's disabled by default, -Dchamelium=disabled is already > being passed to EXTRA_OEMESON. > > In this change, if you add chamelium to PACKAGECONFIG, it will pass > both -Dchamelium=enabled and -Dchamelium=disabled to EXTRA_OEMESON > which is incorrect. It probably works for you because PACKAGECONFIG > arguments are added last ... > > Thanks, > > Anuj > > > > > Thanks, > > Arthur > > > > On Tue, Jul 7, 2020 at 4:43 PM Mittal, Anuj <[email protected]> > > wrote: > > > On Tue, 2020-07-07 at 14:09 -0700, Arthur She wrote: > > > > Chamelium is a hardware device that can be used for external > > > display > > > > test automation [1]. > > > > It is disabled by default and can be turned on through > > > PACKAGECONFIG. > > > > > > > > [1] https://www.chromium.org/chromium-os/testing/chamelium > > > > > > > > Signed-off-by: Arthur She <[email protected]> > > > > --- > > > > meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb | 4 > > > +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/meta/recipes-graphics/igt-gpu-tools/igt-gpu- > > > tools_git.bb > > > > b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb > > > > index f60880c292..29031e64dc 100644 > > > > --- a/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb > > > > +++ b/meta/recipes-graphics/igt-gpu-tools/igt-gpu-tools_git.bb > > > > @@ -20,7 +20,9 @@ RDEPENDS_${PN}-tests += "bash" > > > > > > > > PACKAGE_BEFORE_PN = "${PN}-benchmarks ${PN}-tests" > > > > > > > > -EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled" > > > > +PACKAGECONFIG[chamelium] = "-Dchamelium=enabled,- > > > > Dchamelium=disabled,gsl xmlrpc-c" > > > > + > > > > +EXTRA_OEMESON = "-Ddocs=disabled -Drunner=enabled > > > > -Dchamelium=disabled" > > > > > > This is disabling chamelium even if it's enabled using > > > PACKAGECONFIG. > > > > > > Thanks, > > > > > > Anuj >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140458): https://lists.openembedded.org/g/openembedded-core/message/140458 Mute This Topic: https://lists.openembedded.org/mt/75364233/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
