On 7/13/20 2:29 PM, Max Krummenacher wrote:
Hi

Can we drop this one from the backports?

The patch possibly reduces a bit of build time if lzop-native is not used
by any other recipe, but does not fix anything.

One can build a zImage which is compressed with lzo. For a kernel recipe which
does use a zImage with lzo and relies on the kernel.bbclass to add a depend on
lzop-native the build breaks.


it seems original patch is not adequate yet, perhaps it should also check for KERNEL_IMAGETYPE to have lzo before dropping this dependency, once thats taken care, both together are good for dunfell too.

Cheers
Max

Am Montag, den 13.07.2020, 04:16 -1000 schrieb Steve Sakoman:
From: Timon Ulrich <[email protected]>

a native lzop is only needed when an lzo compressed initramfs is actually 
present

Signed-off-by: Timon Ulrich <[email protected]>
Signed-off-by: Richard Purdie <[email protected]>
(cherry picked from commit 1217ddf070261c5fe523729b2a833bd38f1e4ccd)
Signed-off-by: Steve Sakoman <[email protected]>
---
  meta/classes/kernel.bbclass | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 9e3c34ad48..af7e88b380 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -4,7 +4,8 @@ KERNEL_PACKAGE_NAME ??= "kernel"
  KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == 
"kernel") else
d.getVar("KERNEL_PACKAGE_NAME") }"
PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
-DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc 
kmod-native bc-native
lzop-native bison-native"
+DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc 
kmod-native bc-native
bison-native"
+DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lzo", "lzop-native", 
"", d)}"
  DEPENDS += "${@bb.utils.contains("INITRAMFS_FSTYPES", "cpio.lz4", "lz4-native", 
"", d)}"
  PACKAGE_WRITE_DEPS += "depmodwrapper-cross"




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140602): 
https://lists.openembedded.org/g/openembedded-core/message/140602
Mute This Topic: https://lists.openembedded.org/mt/75477721/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to