Hi Mark,

On Tue, Jul 14, 2020 at 12:49:51PM -0400, Mark Deneen wrote:
> pppd is patched in most Linux distributions to allow arbitrary naming
> of ppp interfaces, allowing users to create consistent firewall rules
> rather than having interfaces named "ppp0", "ppp1", etc.  Yocto is
> missing this option.
> 
> This patch, originally from SUSE, adds this option to pppd. It is not
> included upstream because there are some pppd-supported platforms which
> lack the ability to rename interfaces.
> 
> Upstream-Status: Inappropriate [not all platforms supported by pppd can 
> rename interfaces]
> 

This should probably go....

> Signed-off-by: Mark Deneen <[email protected]>
> ---
>  .../ppp/ppp/0002-pppd-add-ifname-option.patch | 214 ++++++++++++++++++
>  meta/recipes-connectivity/ppp/ppp_2.4.8.bb    |   1 +
>  2 files changed, 215 insertions(+)
>  create mode 100644 
> meta/recipes-connectivity/ppp/ppp/0002-pppd-add-ifname-option.patch
> 
> diff --git 
> a/meta/recipes-connectivity/ppp/ppp/0002-pppd-add-ifname-option.patch 
> b/meta/recipes-connectivity/ppp/ppp/0002-pppd-add-ifname-option.patch
> new file mode 100644
> index 0000000000..8e54024d15
> --- /dev/null
> +++ b/meta/recipes-connectivity/ppp/ppp/0002-pppd-add-ifname-option.patch
> @@ -0,0 +1,214 @@
> +From bbcdc4366bbee6c3f4e1ddda31e4eec8c1b3ccc2 Mon Sep 17 00:00:00 2001
> +From: Paul Mackerras <[email protected]>
> +Date: Tue, 23 Aug 2016 16:10:21 +1000
> +Subject: [PATCH 13/16] pppd: allow use of arbitrary interface names
> +
> +This is a modified version of a patch from openSUSE that enables PPP 
> interfaces
> +to be called arbitrary names, rather than simply pppX where X is the unit
> +number.
> +
> +The modifications from the stock openSUSE patch are:
> +- refresh patch on top of 018_ip-up_option.diff
> +- fix a printf format-string vulnerability in pppd/main.c:set_ifunit()
> +- clarify the pppd.8 manpage additions
> +- patch pppstats/pppstats.c to query renamed interfaces without complaint
> +
> +Origin: SUSE
> +Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=458646
> +Forwarded: no
> +Reviewed-by: Chris Boot <[email protected]>
> +Signed-off-by: Paul Mackerras <[email protected]>

... here ^.

With your Signed-off-by right after?

Also.. Does Yocto support any of such platforms that can't rename
interfaces?

Thanks,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140704): 
https://lists.openembedded.org/g/openembedded-core/message/140704
Mute This Topic: https://lists.openembedded.org/mt/75503096/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to