On Wed, Aug 19, 2020 at 1:49 PM Leon Woestenberg <[email protected]> wrote: > > Hello Adrian, all, > > On Sat, Aug 15, 2020 at 9:55 AM Adrian Bunk <[email protected]> wrote: >> >> On Fri, Aug 14, 2020 at 11:44:17PM +0200, Alexander Kanavin wrote: >> > This needs to go to master first probably? >> >> Better for master might be moving zstd from meta-openembedded, >> and then DEPENDS on zstd-native? >> >> IMHO moving target zstd to OE-core is already overdue, >> so this would not be solely for cmake. >> > > Good point, makes better sense then my proposed fix for cmake-native only. > > More breakage of master against Ubuntu 16.04 (still supported by Yocto) that > supports Adrian's suggestion:
If cmake-native is auto detecting zstd support from the host (and therefore building non-deterministically depending on whether or not the host has zstd development libraries) then the build breakage is just a symptom. Adding zstd to oe-core would be a good approach to fixing the bug for master but not for older releases. > > | > ../../../../../../../work-shared/gcc-10.2.0-r0/gcc-10.2.0/gcc/lto-compress.c: > In function ‘int lto_normalized_zstd_level()’: > | > ../../../../../../../work-shared/gcc-10.2.0-r0/gcc-10.2.0/gcc/lto-compress.c:120:36: > error: ‘ZSTD_maxCLevel’ was not declared in this scope > | else if (level > ZSTD_maxCLevel ()) > | ^ > | > ../../../../../../../work-shared/gcc-10.2.0-r0/gcc-10.2.0/gcc/lto-compress.c: > In function ‘void lto_uncompression_zstd(lto_compression_stream*)’: > | > ../../../../../../../work-shared/gcc-10.2.0-r0/gcc-10.2.0/gcc/lto-compress.c:160:74: > error: ‘ZSTD_getFrameContentSize’ was not declared in this scope > | unsigned long long const rsize = ZSTD_getFrameContentSize (cursor, size); > | ^ > | > ../../../../../../../work-shared/gcc-10.2.0-r0/gcc-10.2.0/gcc/lto-compress.c:161:16: > error: ‘ZSTD_CONTENTSIZE_ERROR’ was not declared in this scope > | if (rsize == ZSTD_CONTENTSIZE_ERROR) > | ^ > | > ../../../../../../../work-shared/gcc-10.2.0-r0/gcc-10.2.0/gcc/lto-compress.c:163:21: > error: ‘ZSTD_CONTENTSIZE_UNKNOWN’ was not declared in this scope > | else if (rsize == ZSTD_CONTENTSIZE_UNKNOWN) > | ^ > | Makefile:1118: recipe for target 'lto-compress.o' failed > | make[1]: *** [lto-compress.o] Error 1 > | make[1]: *** Waiting for unfinished jobs.... > > Did not deep-dive into this, nor test with Adrian's suggestion yet. > > Regards, > > Leon. > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141647): https://lists.openembedded.org/g/openembedded-core/message/141647 Mute This Topic: https://lists.openembedded.org/mt/76196110/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
