I suppose either way is fine, as long as the issue could be resolved.

And I agree, adding a new variable in the local.conf would give more 
flexibility in the built image than the method I applied.
It’s a better solution.


Thank you & Kind regards,
Khairul

-----Original Message-----
From: Richard Purdie <[email protected]> 
Sent: Tuesday, August 25, 2020 6:26 AM
To: Jamaluddin, Khairul Rohaizzat <[email protected]>; 
[email protected]
Subject: Re: [OE-core] [PATCH] wic/bootimg-efi: Added feature to exclude 
IMAGE_BOOT_FILES

On Mon, 2020-08-24 at 14:39 +0800, [email protected] wrote:
> From: Khairul Rohaizzat Jamaluddin 
> <[email protected]>
> 
> Due to recent changes in bootimg-efi to include IMAGE_BOOT_FILES, when 
> both bootimg-partition and bootimg-efi occur in a single .wks and 
> IMAGE_BOOT_FILES are defined, files listed in IMAGE_BOOT_FILES will be 
> duplicated in both partition.
> Since IMAGE_BOOT_FILES are crucial for bootimg-partition, but optional 
> for bootimg-efi, hence allow bootimg-efi to have the option to ignore 
> it.
> 
> The new variable, excludeibf, in bootimg-efi.py need to be set in the 
> .wks file to make use of this feature. Simply remove the variable from 
> the the .wks file if not needed.
> Example:
>     part /boot --source bootimg-efi --sourceparams="loader=systemd-boot,
>     excludeibf=y" --ondisk sda --label msdos --active --align 1024 
> --use-uuid
> 
> [YOCTO #14011]
> 
> Signed-off-by: Khairul Rohaizzat Jamaluddin 
> <[email protected]>
> ---
>  scripts/lib/wic/plugins/source/bootimg-efi.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

I'm torn between this and instead changing efi to use IMAGE_EFI_BOOT_FILES 
instead. Changing the variable would mean more flexibility in how the image is 
constructed...

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#141800): 
https://lists.openembedded.org/g/openembedded-core/message/141800
Mute This Topic: https://lists.openembedded.org/mt/76380555/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to