On 9/2/20 8:27 PM, Bruce Ashfield wrote:
On Wed, Sep 2, 2020 at 8:14 AM Bruce Ashfield via
lists.openembedded.org
<[email protected]> wrote:

On Tue, Sep 1, 2020 at 11:20 PM Xu, Yanfei <[email protected]> wrote:

From: Yanfei Xu <[email protected]>

We just want to remove the first '-I' in $d, hence removing the
'g' of sed avoid changing the real path which is include '-I'


The g was intentional. Is it actually causing a bug ? if not, I see no
reason to change it.

Anyone with paths with embedded '-I' have more issues than this sed expression.

Actually, on further thought. I'll just pull this into my queued patches.

It is my habit to almost always use /g on my sed expressions, but
there's no reason to leave this lurking (but my comment still stands
about configurations that have -I in their actual paths :)


Yes, Bruce. I did meet a bug cause by this reason.... When I looked into
it and found this point.

The path is like "builds/08311812-ICS_Custom/intel-x86-64-standard-small/build"

Thanks,
Yanfei

Bruce


Bruce

Signed-off-by: Yanfei Xu <[email protected]>
---
  meta/classes/kernel-yocto.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-yocto.bbclass 
b/meta/classes/kernel-yocto.bbclass
index 96ea612258..b672a1143a 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -225,7 +225,7 @@ do_kernel_metadata() {
                 for feature in ${KERNEL_FEATURES}; do
                         feature_found=f
                         for d in $includes; do
-                               path_to_check=$(echo $d | sed 's/-I//g')
+                               path_to_check=$(echo $d | sed 's/-I//')
                                 if [ "$feature_found" = "f" ] && [ -e 
"$path_to_check/$feature" ]; then
                                     feature_found=t
                                 fi
--
2.18.2





--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#142124): 
https://lists.openembedded.org/g/openembedded-core/message/142124
Mute This Topic: https://lists.openembedded.org/mt/76575762/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to