Looping in Rasmus, the patch author. Would you like to submit a patch to fix this issue? Otherwise I should probably revert this patch in dunfell.
Thanks! Steve On Fri, Sep 11, 2020 at 3:40 PM Chanho Park <[email protected]> wrote: > > Hi, > > This patch makes STAGING_KERNEL_DIR symlink broken if externalsrc is used. > I filed a bug for this. > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14044 > > Best Regards, > Chanho Park > > On Mon, Aug 31, 2020 at 3:19 AM Steve Sakoman <[email protected]> wrote: > > > > From: Rasmus Villemoes <[email protected]> > > > > There's a race between do_symlink_kernsrc and do_populate_lic, since > > the latter is ordered "after do_patch"; so the two may run in > > parallel. In some cases, that actually causes do_populate_lic to fail > > if it happens to look for a license file somewhere under ${S} in the > > short window after shutil.move and before the symlink has been > > created. > > > > Fix that by simply ordering symlink_kernsrc before do_patch. Any task > > that pokes around in ${S} looking for files should be ordered after > > do_patch, so this should also fix similar latent races with other ad > > hoc tasks. > > > > Signed-off-by: Rasmus Villemoes <[email protected]> > > Signed-off-by: Richard Purdie <[email protected]> > > (cherry picked from commit c5dfc2586b4135cc86e91bb04fed837daf505676) > > Signed-off-by: Steve Sakoman <[email protected]> > > --- > > meta/classes/kernel.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > > index 9e3c34ad48..9eb9bd2844 100644 > > --- a/meta/classes/kernel.bbclass > > +++ b/meta/classes/kernel.bbclass > > @@ -152,7 +152,7 @@ python do_symlink_kernsrc () { > > shutil.move(s, kernsrc) > > os.symlink(kernsrc, s) > > } > > -addtask symlink_kernsrc before do_configure after do_unpack > > +addtask symlink_kernsrc before do_patch after do_unpack > > > > inherit kernel-arch deploy > > > > -- > > 2.17.1 > > > > > > > > -- > Best Regards, > Chanho Park
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#142458): https://lists.openembedded.org/g/openembedded-core/message/142458 Mute This Topic: https://lists.openembedded.org/mt/76518932/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
