In reviewing new master branch commits this morning I see that this patch introduces a bug and a fix patch has been merged.
I will drop this patch from the final pull request and will submit it next week along with the fix (systemd-serialgetty: Replace sed quoting using ' with " to allow var expansion) Steve On Mon, Sep 14, 2020 at 4:12 AM Steve Sakoman via lists.openembedded.org <[email protected]> wrote: > > From: Rahul Kumar <[email protected]> > > Fix sed: -e expression #1, char 13: unterminated `s' command > > Error Message: > | NOTE: Installed into sysroot: [] > | NOTE: Skipping as already exists in sysroot: ['pseudo-native', 'glibc', > 'patch-native', 'quilt-native', 'gcc-cross-arm', 'gcc-runtime', > 'linux-libc-headers', 'libgcc', 'flex-native', 'xz-native', 'libtool-native', > 'automake-native', 'binutils-cross-arm', 'zlib-native', 'mpfr-native', > 'texinfo-dummy-native', 'autoconf-native', 'libmpc-native', > 'gnu-config-native', 'gmp-native', 'attr-native', 'm4-native', > 'gettext-minimal-native'] > | DEBUG: Python function extend_recipe_sysroot finished > | DEBUG: Executing shell function do_install > | sed: -e expression #1, char 13: unterminated `s' command > | WARNING: exit code 1 from a shell command. > | ERROR: Execution of > '/opt/Projects/poky/build/tmp/work/qemux86_64-poky-linux/systemd-serialgetty/1.0-r5/temp/run.do_install.11228' > failed with exit code 1: > | sed: -e expression #1, char 13: unterminated `s' command > | WARNING: exit code 1 from a shell command. > | > > To Fix this Issue using the strong (single quote) character in sed command. > It is recommend to use quotes. If we have meta-characters in the command, > quotes are necessary. > > Signed-off-by: Rahul Kumar <[email protected]> > Signed-off-by: Richard Purdie <[email protected]> > (cherry picked from commit e2fea05e150dcfec4b7dfbd8edddb53897026bf9) > Signed-off-by: Steve Sakoman <[email protected]> > --- > meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/systemd/systemd-serialgetty.bb > b/meta/recipes-core/systemd/systemd-serialgetty.bb > index 044c6c5b67..059fccc2b6 100644 > --- a/meta/recipes-core/systemd/systemd-serialgetty.bb > +++ b/meta/recipes-core/systemd/systemd-serialgetty.bb > @@ -21,7 +21,7 @@ do_install() { > install -d ${D}${systemd_unitdir}/system/ > install -d > ${D}${sysconfdir}/systemd/system/getty.target.wants/ > install -m 0644 ${WORKDIR}/[email protected] > ${D}${systemd_unitdir}/system/ > - sed -i -e s/\@BAUDRATE\@/$default_baudrate/g > ${D}${systemd_unitdir}/system/[email protected] > + sed -i -e 's/\@BAUDRATE\@/$default_baudrate/g' > ${D}${systemd_unitdir}/system/[email protected] > > tmp="${SERIAL_CONSOLES}" > for entry in $tmp ; do > -- > 2.17.1 > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#142531): https://lists.openembedded.org/g/openembedded-core/message/142531 Mute This Topic: https://lists.openembedded.org/mt/76843324/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
