On Mon, Sep 21, 2020 at 6:51 PM Richard Purdie <[email protected]> wrote: > > On Mon, 2020-09-21 at 23:23 +0200, Yann Dirson wrote: > > > > > > Le lun. 21 sept. 2020 à 21:46, Richard Purdie < > > [email protected]> a écrit : > > > On Mon, 2020-09-21 at 16:15 +0200, Yann Dirson wrote: > > > > From: Yann Dirson <[email protected]> > > > > > > > > --- > > > > meta/classes/systemtap.bbclass | 74 > > > +++++++++++++++++++ > > > > .../systemtap/systemtap-demo_git.bb | 71 > > > ++++++++++++++++++ > > > > 2 files changed, 145 insertions(+) > > > > create mode 100644 meta/classes/systemtap.bbclass > > > > create mode 100644 meta/recipes-kernel/systemtap/systemtap- > > > demo_git.bb > > > > > > I'm afraid this patch is going to throw warnings all over the > > > autobuilder, e.g.: > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/2488 > > > > > > (and there will be more). > > > > > > We are trying to ensure all warnings are solved so that any that do > > > show are real issues and this patch would significantly distract > > > from > > > that. > > > > OK, we could default to built just the handful of probes that should > > always build, and give instructions for those willing to use the > > current behaviour. > > I think that is going to be safer and we could grow into more examples > if/as/when we van build them.
Also, as the person that usually picks up systemtap breakage first on our new kernel versions .. we need to make sure that the reworked recipe and class pass the oe-selftest for stap. It is doing on target compilation, so ideally, that test should be expanded to test bot the cross and on-target variants. Cheers, Bruce > > > > > > I'm also wary that we're now in feature freeze for release so > > > perhaps > > > these changes should wait until 3.3? > > > > OK, I can reroll a series with just the fixes. > > That would be great. > > > For the rest should I just wait for the gatesgarth branch to be > > created and resubmit then ? > > Once we start taking new work on master, yes. > > Also, for a new recipe like this we need a maintainers entry, else we > see: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/1377 > > Cheers, > > Richard > > > > > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#142703): https://lists.openembedded.org/g/openembedded-core/message/142703 Mute This Topic: https://lists.openembedded.org/mt/76990992/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
