Hi Alex, Yes this test took around 5 minutes to be completed. But since it is not acceptable and not reasonable for a test case to take up so much time. I will rework on it.
Thanks for the feedback. Best Regards, Jay From: Alexander Kanavin <[email protected]> Sent: Monday, 9 November, 2020 4:34 PM To: Teoh, Jay Shen <[email protected]> Cc: OE-core <[email protected]> Subject: Re: [OE-core] [PATCH] oeqa/terminal : rework the logic Does this test take 5 minutes to complete? This is too much, it should only be a few seconds. Alex On Mon, 9 Nov 2020 at 09:30, Teoh, Jay Shen <[email protected]<mailto:[email protected]>> wrote: From: Teoh Jay Shen <[email protected]<mailto:[email protected]>> Rework this test case to fulfill the requirements of replacing the click_terminal_icon_on_X_desktop manual test case from oeqa/manual/bsp-hw : 1) code added to verify that the terminal window is working without problem 2) code added to verify that there's only 1 terminal window is launched Signed-off-by: Teoh Jay Shen <[email protected]<mailto:[email protected]>> --- meta/lib/oeqa/runtime/cases/terminal.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/meta/lib/oeqa/runtime/cases/terminal.py b/meta/lib/oeqa/runtime/cases/terminal.py index a268f26..8a079a5 100644 --- a/meta/lib/oeqa/runtime/cases/terminal.py +++ b/meta/lib/oeqa/runtime/cases/terminal.py @@ -2,17 +2,22 @@ from oeqa.runtime.case import OERuntimeTestCase from oeqa.core.decorator.depends import OETestDepends from oeqa.runtime.decorator.package import OEHasPackage -import threading -import time +import re class TerminalTest(OERuntimeTestCase): @OEHasPackage(['matchbox-terminal']) @OETestDepends(['ssh.SSHTest.test_ssh']) def test_terminal_running(self): - t_thread = threading.Thread(target=self.target.run, args=('export DISPLAY=:0 && matchbox-terminal',)) - t_thread.start() - time.sleep(2) + + status, output = self.target.run("export DISPLAY=:0 && matchbox-terminal",) + check_terminal = re.search("Process killed - no output for 300 seconds.", output) + self.assertTrue(check_terminal, msg='Terminal window should be launched without any problem') + + status, output = self.target.run('pidof matchbox-terminal | wc -w') + output = int(output) + self.assertEqual(output, 1, 'There should be only one terminal window being launched. Terminal window launched : %s' % output) + status, output = self.target.run('pidof matchbox-terminal') self.target.run('kill -9 %s' % output) self.assertEqual(status, 0, msg='Not able to find process that runs terminal.') -- 2.7.4
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#144432): https://lists.openembedded.org/g/openembedded-core/message/144432 Mute This Topic: https://lists.openembedded.org/mt/78131664/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
