Hi Shachar,

On 2020-11-18 1:49 p.m., Shachar Menashe wrote:
About the busybox patch, I realized that Dunfell doesn't come with the 
"openssl" binary built-in (only the library) but this fix will actually 
requires having the openssl binary (busybox invokes the openssl binary directly)
Do you think it's reasonable to add it? The library is already getting built, 
so I don't think it's a huge deal to add the binary as well

For dunfell, you need to ask Steve and the oe-core list.
I've CCed both Steve and the list here.

Typically we would not add components to an image after release
but since you have a bug that adding openssl-bin fixes, that's
a different story. You would need to add a dependency
on openssl-bin from busybox. That seems wrong since it'll
increase the size of core-image-minimal.


I'm thinking we would need to add "openssl-bin" to the openssl recipe 
somewhere, right?

The openssl recipe on master already produces:

$ ls tmp-glibc/work/core2-64-wrs-linux/openssl/1.1.1h-r0/packages-split/
libcrypto            libssl.shlibdeps  openssl-bin.shlibdeps openssl-dev      openssl-engines.shlibdeps  openssl-src libcrypto.shlibdeps  openssl           openssl-conf openssl-doc      openssl-locale             openssl-staticdev libssl               openssl-bin       openssl-dbg openssl-engines  openssl-misc


An example of a dependency on openssl-bin is:

$ cd .../oe-core.git
$ rg openssl-bin
...
meta/recipes-support/ca-certificates/ca-certificates_20200601.bb
87:RDEPENDS_${PN}_class-target = "openssl-bin"
89:RDEPENDS_${PN}_class-nativesdk = "nativesdk-openssl-bin"

so without looking carefully at the busybox recipe, I do wonder
if you just need an *optional* dependency on ca-certificates.

Looking at the busybox recipe, it would be better to have busybox-wget
depend on openssl-bin like:

# busybox's unzip test case needs zip command, which busybox itself does not provide
RDEPENDS_${PN}-ptest = "zip"

of course a busybox-wget only component/alternative doesn't seem to exist yet:

$ ls tmp-glibc/work/core2-64-oe-linux/busybox/1.32.0-r0/packages-splt
busybox      busybox-dev  busybox-httpd    busybox-locale busybox.shlibdeps  busybox-staticdev  busybox-udhcpc busybox-dbg  busybox-doc  busybox-hwclock  busybox-mdev busybox-src        busybox-syslog     busybox-udhcpd

so you'd have to separate that out like we have for -syslog and -httpd, etc.

It's more work than you signed up for but I'm pretty sure that people
are not going to want to have our default core-image-minimal include
openssl-FOO and increase in size.

$ grep busybox tmp-glibc/deploy/images/qemux86-64/core-image-minimal-qemux86-64-20201117232559.rootfs.manifest
busybox core2-64 1.32.0-r0
busybox-hwclock core2-64 1.32.0-r0
busybox-syslog core2-64 1.32.0-r0
busybox-udhcpc core2-64 1.32.0-r0

$ grep openssl tmp-glibc/deploy/images/qemux86-64/core-image-minimal-qemux86-64-20201117232559.rootfs.manifest
NULL
$

Hopefully someone opinionated about busybox will make a suggestion
on how to resolve this bug.

../Randy


# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144790): 
https://lists.openembedded.org/g/openembedded-core/message/144790
Mute This Topic: https://lists.openembedded.org/mt/78352776/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to