On Mon, 2020-11-30 at 14:07 -0800, Chandana kalluri wrote: > The current implementation will always pick an existing templateconf.cfg if > present else it will use the one from OE. A user might not always want to > pick > an existing tempalteconf.cfg even if its present. Introduce > CUSTOM_TEMPLATECONF variable to provide an option for the user to specify if > he > wants to use an existing custom templateconf.cfg or not > > If CUSTOM_TEMPLATECONF=='1' then enable custom templateconf.cfg. By default > CUSTOM_TEMPLATECONF is set to '0' > > Signed-off-by: Sai Hari Chandana Kalluri <[email protected]> > --- > meta/classes/populate_sdk_ext.bbclass | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/populate_sdk_ext.bbclass > b/meta/classes/populate_sdk_ext.bbclass > index 6f35b61..d1f61d5 100644 > --- a/meta/classes/populate_sdk_ext.bbclass > +++ b/meta/classes/populate_sdk_ext.bbclass > @@ -24,6 +24,7 @@ SDK_INCLUDE_NATIVESDK ?= "0" > SDK_INCLUDE_BUILDTOOLS ?= '1' > > SDK_RECRDEP_TASKS ?= "" > +CUSTOM_TEMPLATECONF ?= "0"
Please use an SDK_ prefix for this since then its at least consistent with the other variables we have here. Other than that its probably ok although I'd prefer not to have a ton of these variables but have configurations which "just work" for people. I think this is a sign this code needs reworking somehow. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#145264): https://lists.openembedded.org/g/openembedded-core/message/145264 Mute This Topic: https://lists.openembedded.org/mt/78619994/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
