On Wed, Dec 16, 2020 at 10:57 AM Alan Perry <[email protected]> wrote: > > > > On 12/16/20 10:27 AM, Khem Raj wrote: > > On Tue, Dec 15, 2020 at 11:38 PM Alan Perry <[email protected]> wrote: > >> Add a package for libopcodes, since, like libbfd, it is needed by > >> perf. Without separate packages for these libraries, all of the > >> binutil tools get added as well. > >> > > libopcodes is not an API that binutils publish for wider consumption, > > its meant for internal components and > > external components can use it from binutils itself knowing very well > > that it will change with binutils and therefore > > I would prefer to not separate it out into separate package like this > > which can appear as if its an external API > > that binutils will respect. > > Currently in binutils, the libbfd package is there "so including perf > doesn't include extra stuff". > > Without this change, including perf includes that extra stuff anyway. > > If that comment is to be believed, the libbfd is not currently being > provided in binutils as an external API.
yes libbfd should also have not been done this way as well but I guess there are more than one user for libbfd which tilted in its favor. > > > > > >> Signed-off-by: Alan Perry <[email protected]> > >> --- > >> meta/recipes-devtools/binutils/binutils_2.35.bb | 6 ++++-- > >> 1 file changed, 4 insertions(+), 2 deletions(-) > >> > >> diff --git a/meta/recipes-devtools/binutils/binutils_2.35.bb > >> b/meta/recipes-devtools/binutils/binutils_2.35.bb > >> index 2e645e1ed8..976e49765a 100644 > >> --- a/meta/recipes-devtools/binutils/binutils_2.35.bb > >> +++ b/meta/recipes-devtools/binutils/binutils_2.35.bb > >> @@ -52,9 +52,11 @@ do_install_class-native () { > >> rmdir ${D}/${libdir}64 || : > >> } > >> > >> -# Split out libbfd-*.so so including perf doesn't include extra stuff > >> -PACKAGE_BEFORE_PN += "libbfd" > >> +# Split out libbfd-*.so and libopcodes-*.so so including perf doesn't > >> include > >> +# extra stuff > >> +PACKAGE_BEFORE_PN += "libbfd libopcodes" > >> FILES_libbfd = "${libdir}/libbfd-*.so.* ${libdir}/libbfd-*.so" > >> +FILES_libopcodes = "${libdir}/libopcodes-*.so.* ${libdir}/libopcodes-*.so" > >> > >> SRC_URI_append_class-nativesdk = " > >> file://0003-binutils-nativesdk-Search-for-alternative-ld.so.conf.patch " > >> > >> -- > >> 2.17.1 > >> > >> > >> > >> >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#145786): https://lists.openembedded.org/g/openembedded-core/message/145786 Mute This Topic: https://lists.openembedded.org/mt/78996080/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
