On Thu, Dec 17, 2020 at 3:51 PM Andre McCurdy <[email protected]> wrote: > > On Thu, Dec 17, 2020 at 2:54 PM Khem Raj <[email protected]> wrote: > > > > Helps to execute it with busybox shell > > How does it help? Adding quotes would help if $rootcheck is an empty > string, but that's not specific to busybox. > > > Signed-off-by: Khem Raj <[email protected]> > > --- > > meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh > > b/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh > > index 02f0351fcb..a63e71b780 100755 > > --- a/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh > > +++ b/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh > > @@ -74,7 +74,7 @@ test "$VERBOSE" != no && echo "Activating swap" > > # > > # Check the root filesystem. > > # > > -if test -f /fastboot || test $rootcheck = no > > +if test -f /fastboot || test "$rootcheck" = "no" > > then > > test $rootcheck = yes && echo "Fast boot, no filesystem check" > > Doesn't this instance need to be quoted too?
yes infact there are more cleanup to follow, this series just fixed default boot errors on reference images. > > > else > > -- > > 2.29.2 > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#145833): https://lists.openembedded.org/g/openembedded-core/message/145833 Mute This Topic: https://lists.openembedded.org/mt/79049546/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
