Hello, On Mon, 28 Dec 2020 at 02:48, Dmitry Baryshkov <[email protected]> wrote: > > Change rxvt-unicode from using PROVIDES to RPROVIDES for > x-terminal-emulator, since the package provides x-terminal-emulator > functionality at runtime rather than at build time. > > Signed-off-by: Dmitry Baryshkov <[email protected]>
I'd like to ping for this patch. Is there something wrong with it? Having "virtual/x-terminal-emulator" in PROVIDES is the wrong idea in my opinion. Other recipes can require virtual/x-terminal-emulator in runtime, rather than at the build time. > --- > meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc > b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc > index b064a63caa66..6ebd3afcb939 100644 > --- a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc > +++ b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc > @@ -14,7 +14,7 @@ SRC_URI = > "http://dist.schmorp.de/rxvt-unicode/Attic/rxvt-unicode-${PV}.tar.bz2 > > inherit autotools pkgconfig update-alternatives > > -PROVIDES = "virtual/x-terminal-emulator" > +RPROVIDES_${PN} = "virtual/x-terminal-emulator" > ALTERNATIVE_${PN} = "x-terminal-emulator" > ALTERNATIVE_TARGET[x-terminal-emulator] = "${bindir}/rxvt" > > -- > 2.29.2 > -- With best wishes Dmitry
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#146560): https://lists.openembedded.org/g/openembedded-core/message/146560 Mute This Topic: https://lists.openembedded.org/mt/79259979/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
