Hi Dorinda, On Tue, Jan 26, 2021 at 02:33:59AM +0100, Dorinda wrote: > If a user executes the environment script instead of sourcing it, there's an > error about an empty element in PATH. This is because bitbake isn't present > in environment variable PATH. Hence, this patch adds a sanity check to verify > if bitbake is present in PATH and if bitbake isn't present issue a warning > message. >
Same remarks as your other patch for the pseudo related fix. => v2 + commit log wrap Your patch also has [PATCH 1/2] but there's no second patch AFAICT, you might want to check the content of the patch before sending it (you can read the patch with your favorite text editor, it's just text). I think git send-email also asks you if you want to send the mail with the subject being "<insert commit title>" before actually sending it but I'm not sure anymore. Still only nitpicks so no need to send a v3 on my side. Cheers, Quentin
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147247): https://lists.openembedded.org/g/openembedded-core/message/147247 Mute This Topic: https://lists.openembedded.org/mt/80121254/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
