> -----Original Message----- > From: [email protected] <openembedded- > [email protected]> On Behalf Of Khem Raj via > lists.openembedded.org > Sent: 29 January 2021 02:16 > To: Tom Hochstein <[email protected]>; openembedded- > [email protected] > Cc: [email protected] > Subject: Re: [OE-core] [PATCH] [RFC] openssl: Enable cryptodev-linux by > default > > > > On 1/28/21 1:35 PM, Tom Hochstein wrote: > > This is a Request for Comment. Would it be a good idea to enable > cryptodev-linux > > by default, gaining hardware acceleration where supported? Are there any > > unacceptable drawbacks? What happens on hardware without > acceleration? > > > > this perhaps helps with devices that include a hardware crypto device > but not as much with one;s thats fine but we use qemu machines quite a > bit in testing so it would be good to get a readout on qemu secondly, if > it does not, then maybe we should see if defining it via > MACHINE_FEATUREs might be an option to enable it. >
I think that making it a MACHINE_FEATURES would effectively make the task signatures for openssl be machine dependent and that would also make all recipes which depend directly or indirectly on openssl (and there are a lot!) have their task signatures be machine dependent, so they would need to have their PACKAGE_ARCH set to MACHINE_ARCH to avoid triggering spurious rebuilds when switching between machines with and without cryptodev-linux in MACHINE_FEATURES. So MACHINE_FEATURES does not look like a viable option, a DISTRO_FEATURES might be, although it does not really look like a nice fit either. > > Signed-off-by: Tom Hochstein <[email protected]> > > --- > > meta/recipes-connectivity/openssl/openssl_1.1.1i.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1i.bb > b/meta/recipes-connectivity/openssl/openssl_1.1.1i.bb > > index 5617f337e0..d4c19f1a52 100644 > > --- a/meta/recipes-connectivity/openssl/openssl_1.1.1i.bb > > +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1i.bb > > @@ -28,7 +28,7 @@ SRC_URI[sha256sum] = > "e8be6a35fe41d10603c3cc635e93289ed00bf34b79671a3a4de64fcee0 > > inherit lib_package multilib_header multilib_script ptest > > MULTILIB_SCRIPTS = "${PN}-bin:${bindir}/c_rehash" > > > > -PACKAGECONFIG ?= "" > > +PACKAGECONFIG ?= "cryptodev-linux" > > PACKAGECONFIG_class-native = "" > > PACKAGECONFIG_class-nativesdk = "" > > > > > > > > > > > > -- Diego Santa Cruz, PhD Technology Architect spinetix.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147429): https://lists.openembedded.org/g/openembedded-core/message/147429 Mute This Topic: https://lists.openembedded.org/mt/80195674/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
