Hi Everyone, Just a friendly reminder to review this patch. Thanks, Dorinda.
On Feb 1, 2021 3:46 PM, "dorindabassey" <[email protected]> wrote: > Tinfoil doesn't behave well if environment is not initialized, this check > ensures a proper error log if environment is not initialized. > > [YOCTO #12096] > > Signed-off-by: Dorinda Bassey <[email protected]> > --- > v2: > -Positioned check under a condition when it cannot determine the > pkgdata_dir > > scripts/oe-pkgdata-util | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/oe-pkgdata-util b/scripts/oe-pkgdata-util > index 93220e3617..75dd23efa3 100755 > --- a/scripts/oe-pkgdata-util > +++ b/scripts/oe-pkgdata-util > @@ -598,6 +598,9 @@ def main(): > logger.error("Unable to find bitbake by searching parent > directory of this script or PATH") > sys.exit(1) > logger.debug('Found bitbake path: %s' % bitbakepath) > + if not os.environ.get('BUILDDIR', ''): > + logger.error("This script can only be run after initialising > the build environment (e.g. by using oe-init-build-env)") > + sys.exit(1) > tinfoil = tinfoil_init() > try: > args.pkgdata_dir = tinfoil.config_data.getVar('PKGDATA_DIR') > -- > 2.17.1 > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147769): https://lists.openembedded.org/g/openembedded-core/message/147769 Mute This Topic: https://lists.openembedded.org/mt/80286903/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
