Le lun. 8 févr. 2021 à 18:55, Konrad Weihmann <[email protected]> a
écrit :

>
>
> On 08.02.21 18:52, Yoann Congal wrote:
> > The current recipe unconditionally RDEPENDS on nodejs (the target one).
> > When building on the "-native recipe" of "BBCLASSEXTEND native" recipe,
> > the target nodejs is unnecessarily built.
> >
> > This patch fixes this by only RDEPENDS on nodejs when building for the
> target.
> >
> > Signed-off-by: Yoann Congal <[email protected]>
> > ---
> >   meta/classes/npm.bbclass | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
> > index 79f55febcc..61d16cf23d 100644
> > --- a/meta/classes/npm.bbclass
> > +++ b/meta/classes/npm.bbclass
> > @@ -20,7 +20,7 @@
> >   inherit python3native
> >
> >   DEPENDS_prepend = "nodejs-native "
> > -RDEPENDS_${PN}_prepend = "nodejs "
> > +RDEPENDS_${PN}_class-target_prepend += "nodejs"
>
> This doesn't look right. Either
>
> RDEPENDS_${PN}_class-target_prepend = "nodejs "
>   or
> RDEPENDS_${PN}_class-target += "nodejs"
>
> but not both. plus prepend does require a trailing blank iirc
>

Oh wow, I should not have missed that :-/

I'll send a PATCHv2.

Thanks!


> >
> >   NPM_INSTALL_DEV ?= "0"
> >
> >
> >
> >
> >
> >
>
> 
>
>

-- 
Yoann Congal
Smile ECS - Expert technique
[email protected]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#147832): 
https://lists.openembedded.org/g/openembedded-core/message/147832
Mute This Topic: https://lists.openembedded.org/mt/80483928/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to