On Wed, 2012-01-04 at 00:50 +0000, Paul Eggleton wrote: > On Tuesday 03 January 2012 15:54:12 Saul Wold wrote: > > On 12/28/2011 05:43 AM, Paul Eggleton wrote: > > > Implement locale package installation as we had in OE-Classic; please > > > review. In particular I'm not sure of the naming of > > > rootfs_check_package_exists() (since it resolves the package to a > > > filename in the case of RPM). Note that because of the default value of > > > IMAGE_LINGUAS this patch will result in images growing slightly. > > > > Merged into OE-Core > > Er, this was actually an RFC patch and I was hoping to get some more review > and comments especially as it came during the holidays... > > It may be too late to stop it going in but if anyone has any comments/issues > please raise them now and we can look at further patches if necessary.
To be honest, I'm not happy with the current rootfs/package code as there are way too many differences between the backends and too much duplicated code. Its heading towards being an unmaintainable mess. Your patch starts to unwind some of that so as far as I'm concerned that is a good thing. I'd not realised it was an RFC when it was presented as part of the consolidated pull but I think its a good thing to have in. I'd really like to see more patches like that one. Cheers, Richard _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
