Thanks Khem, this makes sense. Alex
On Tue, 9 Mar 2021 at 05:05, Khem Raj <[email protected]> wrote: > On Mon, Mar 8, 2021 at 7:50 PM Alexander Kanavin <[email protected]> > wrote: > > > > Can you please explain the context for this? Why would we want to > support building webkit on such constrained machines? 8g of ram means they > can’t run more than 4-6 gcc processes, so webkit builds will be unbearably > slow anyway. > > > > this helps to avoid unwanted build breaks since gcc crashes when > memory pressure is too high, > when doing parallel builds this can happen very often since there are > other tasks running in parallel, so these situations can arise often > we have seen this happen on machines with 16GB RAM > therefore saving some of the memory during linking helps reduce these > breakages. they can still happen if say machine was doing more than 1 > builds in parallel but at least tools have done what they could. > > > Alex > > > > On Tue 9. Mar 2021 at 1.00, Khem Raj <[email protected]> wrote: > >> > >> Helps builds on machines with less RAM ( 8G ) > >> > >> Signed-off-by: Khem Raj <[email protected]> > >> --- > >> .../webkitgtk/reduce-memory-overheads.patch | 22 +++++++++++++++++++ > >> meta/recipes-sato/webkit/webkitgtk_2.30.5.bb | 1 + > >> 2 files changed, 23 insertions(+) > >> create mode 100644 > meta/recipes-sato/webkit/webkitgtk/reduce-memory-overheads.patch > >> > >> diff --git > a/meta/recipes-sato/webkit/webkitgtk/reduce-memory-overheads.patch > b/meta/recipes-sato/webkit/webkitgtk/reduce-memory-overheads.patch > >> new file mode 100644 > >> index 0000000000..0493150a91 > >> --- /dev/null > >> +++ b/meta/recipes-sato/webkit/webkitgtk/reduce-memory-overheads.patch > >> @@ -0,0 +1,22 @@ > >> +From: Alberto Garcia <[email protected]> > >> +Subject: Reduce memory usage when not using the Gold linker > >> +Bug-Debian: https://bugs.debian.org/949621 > >> +Forwarded: no > >> + > >> +Upstream-Status: Pending > >> +Signed-off-by: Khem Raj <[email protected]> > >> +--- a/Source/cmake/OptionsCommon.cmake > >> ++++ b/Source/cmake/OptionsCommon.cmake > >> +@@ -95,6 +95,12 @@ option(GCC_OFFLINEASM_SOURCE_MAP > >> + "Produce debug line information for offlineasm-generated code" > >> + ${GCC_OFFLINEASM_SOURCE_MAP_DEFAULT}) > >> + > >> ++# Pass --reduce-memory-overheads to the bfd linker in order to save > memory > >> ++if (NOT USE_LD_GOLD) > >> ++ set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} > -Wl,--reduce-memory-overheads") > >> ++ set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} > -Wl,--reduce-memory-overheads") > >> ++endif () > >> ++ > >> + # Enable the usage of OpenMP. > >> + # - At this moment, OpenMP is only used as an alternative > implementation > >> + # to native threads for the parallelization of the SVG filters. > >> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.30.5.bb > b/meta/recipes-sato/webkit/webkitgtk_2.30.5.bb > >> index 2928b8e55b..a1dd76ce81 100644 > >> --- a/meta/recipes-sato/webkit/webkitgtk_2.30.5.bb > >> +++ b/meta/recipes-sato/webkit/webkitgtk_2.30.5.bb > >> @@ -18,6 +18,7 @@ SRC_URI = " > https://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \ > >> file://0001-Fix-build-with-musl.patch \ > >> file://include_array.patch \ > >> file://include_xutil.patch \ > >> + file://reduce-memory-overheads.patch \ > >> " > >> SRC_URI[sha256sum] = > "7d0dab08e3c5ae07bec80b2822ef42e952765d5724cac86eb23999bfed5a7f1f" > >> > >> -- > >> 2.30.1 > >> > >> > >> > >> >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#149156): https://lists.openembedded.org/g/openembedded-core/message/149156 Mute This Topic: https://lists.openembedded.org/mt/81189464/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
