On Tue, Mar 9, 2021 at 7:23 AM Frans Meulenbroeks <fransmeulenbro...@yahoo.com> wrote: > > Freaking yahoo email seems to have no option any more to quote decently. > Guess it is time for a new email provider :-) > Anyway my response below prefixed with FM: > > Op dinsdag 9 maart 2021 00:26:05 CET schreef Khem Raj <raj.k...@gmail.com>: > On 3/8/21 2:25 PM, Andre McCurdy wrote: > > On Mon, Mar 8, 2021 at 2:15 PM Khem Raj <raj.k...@gmail.com> wrote: > >> > >> On 3/8/21 2:11 PM, Andre McCurdy wrote: > >>> On Mon, Mar 8, 2021 at 11:30 AM Khem Raj <raj.k...@gmail.com> wrote: > >>>> > >>>> From: Frans Meulenbroeks <fransmeulenbro...@yahoo.com> > >>>> > >>>> resolvconf uses flock and readlink. > >>>> So explicitly added dependencies on util-linux (for flock) and coreutils > >>>> (for readlink). > >>>> Note that the options used with flock and readlink are not part of the > >>>> busybox implementations so full-fledged implementations are needed. > >>>> > >>>> Signed-off-by: Khem Raj <raj.k...@gmail.com> > >>>> --- > >>>> meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb > >>>> b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb > >>>> index 6df96b699c..6da8cd6023 100644 > >>>> --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb > >>>> +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb > >>>> @@ -9,7 +9,7 @@ LICENSE = "GPLv2+" > >>>> LIC_FILES_CHKSUM = > >>>> "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" > >>>> AUTHOR = "Thomas Hood" > >>>> HOMEPAGE = "http://packages.debian.org/resolvconf"; > >>>> -RDEPENDS_${PN} = "bash" > >>>> +RDEPENDS_${PN} = "bash coreutils util-linux" > >>> > >>> util-linux-flock has its own package. > >> > >> yeah and busybox also provides flock too. Lets drop it > > > > Busybox provides flock, but it doesn't support the -w option (wait > > with timeout). Either the util-linux flock is required or resolvconf > > needs to be patched to drop the -w option. > > right, its to explore possibilities to avoid the deps. > > FM: While I am all in favor of avoiding these dependencies, I'm not versed > enough in the resolvconf code to judge the impact of dropping -w, so my > preference would be to depend on util-linux-flock.
Agreed. Adding a runtime dependency on util-linux-flock is the safest fix. > >>> Patching resolvconf to use readlink -f (instead of readlink -m) should > >>> be sufficient to allow it to work with busybox readlink. > > FM: this will most likely work. I can make a patch for that, no problem. For reference, there's a patch which does that here: https://github.com/lgirdk/meta-mng/blob/ofw/recipes-misc/resolvconf/resolvconf/0001-try-to-support-busybox-readlink.patch > >>>> SRC_URI = > >>>> "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable > >>>> \ > >>>> file://fix-path-for-busybox.patch \ > >>>> -- > >>>> 2.30.1 > > On a general note: in the current form the package is broken, so some fix is > desirable. Agreed.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#149201): https://lists.openembedded.org/g/openembedded-core/message/149201 Mute This Topic: https://lists.openembedded.org/mt/81183177/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
