On 3/18/21 1:45 PM, Khem Raj wrote:
[Please note: This e-mail is from an EXTERNAL e-mail address]
On Wed, Mar 17, 2021 at 10:40 PM Yu, Mingli <[email protected]> wrote:
Hi Khem,
Understood your concern, but skip elfutils here is the least code change
and the gettext also use this means previously.
gettext perhaps can be pardoned since its the one providing these
macros in first place.
Meanwhile, there should as least as possible recipe need to skip wiping
macros. If no, we may need to reconsider the related implement in
autotools.bbclass. From this perspective, I think we should better
record the recipe in this general bbclass.
I agree, but so far it seems its only elfutils, if there are more then
please mentioned then to the list
and perhaps a different solution should be sought.
Currently only found elfutils has this problem in my env. I think
firstly if only one recipe, it's no big deal to record here as we wipe
the per recipe macros in this autotools.bbclass(I didn't find other
distribution wipe the macros). And secondly if there are other recipes
need to skip the wiping, then it's just right to record here to prove we
need to reconsider the related implements in autotools.bbclass.
Thanks,
Thanks,
On 3/18/21 11:05 AM, Yu, Mingli wrote:
From: Mingli Yu <[email protected]>
The below m4 macros files shipped with recipe will be removed if the
recipe use AM_GNU_GETTEXT.
gettext.m4
iconv.m4
lib-ld.m4
lib-link.m4
lib-prefix.m4
nls.m4 po.m4
progtest.m4
After elfutils upgrades to 0.183, it begins to use AM_GNU_GETTEXT as the
commit (dd52d2ab Modernize gettext infrastructure) included, so the above
m4 macros files such as iconv.m4 is removed and it's bad as we need to
patch against iconv.m4 shippped with elfutils.
So we skip elfutils to not let the elfutils m4 macros removed and also
fix below issue:
$ bitbake elfutils -cconfigure && bitbake elfutils -cpatch -f
Signed-off-by: Mingli Yu <[email protected]>
---
meta/classes/autotools.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index 9dc8ebdaa7..4b462c5aba 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -203,7 +203,7 @@ autotools_do_configure() {
bbnote Executing glib-gettextize --force --copy
echo "no" | glib-gettextize --force --copy
fi
- elif [ "${BPN}" != "gettext" ] && grep -q
"^[[:space:]]*AM_GNU_GETTEXT" $CONFIGURE_AC; then
+ elif [ "${BPN}" != "gettext" -a "${BPN}" != "elfutils" ] && grep -q
"^[[:space:]]*AM_GNU_GETTEXT" $CONFIGURE_AC; then
# We'd call gettextize here if it wasn't so broken...
cp ${STAGING_DATADIR_NATIVE}/gettext/config.rpath
${AUTOTOOLS_AUXDIR}/
if [ -d ${S}/po/ ]; then
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149621):
https://lists.openembedded.org/g/openembedded-core/message/149621
Mute This Topic: https://lists.openembedded.org/mt/81421565/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
