Hi Ida, On Tue, 2021-03-16 at 09:48 +0100, Meh Mbeh Ida Delphine wrote: > The logic to obtain filelics is moved from package.bbclass to license.py > as a standalone function. > Also, the check in package.bbclass after obtaining filelics ensures licenses > with * WITH Linux-syscall-note" are ignored, as long as they're only in > header files. > > Signed-off-by: Ida Delphine <idad...@gmail.com> > --- > meta/classes/package.bbclass | 35 ++++++++++++----------------------- > meta/lib/oe/license.py | 29 +++++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 23 deletions(-)
I have spent quite a bit of time thinking about this patchset and I'm not sure we're yet into a position where it can merge. The code has definitely moved on from where things started but I'm not sure it is far enough along to be useful to others yet in this form. For example, we should only ever generate warnings if there is a clear path the user needs to take or a clear benefit for fixing it. The warnings from this code, whilst reduced from where they were, are still going to be large in number and not focused enough for general use. I realise I added the warnings in the original code but the idea was that was only a temporary thing to help debug it with and illustrate what it was doing, it was never intended to merge like that. Ultimately a warning should only be shown when we know there is something serious wrong. If this data was being written to a log for someone to review, that would perhaps be better but even then, I'm not sure the quality of the output data is yet high enough for that to be useful for people review. Some of the function abstraction does look useful but it is entwined in with the rest of the patches so can't be merged without them I do also have some concerns about the function names, I think they'd need to be improved before it could be merged too. What we do have here is a set of building blocks that the next steps in license development can take place from so its good to have the progress. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#150023): https://lists.openembedded.org/g/openembedded-core/message/150023 Mute This Topic: https://lists.openembedded.org/mt/81371634/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
