On Thu, Apr 1, 2021 at 10:07 AM Andre McCurdy <armccu...@gmail.com> wrote:
>
> On Thu, Apr 1, 2021 at 8:29 AM Steve Sakoman <st...@sakoman.com> wrote:
> >
> > From: "Robert P. J. Day" <rpj...@crashcourse.ca>
> >
> > There is apparently no functional value to "PROVIDES" lines anymore in
> > packagegroup recipe files, so remove the lonely couple of examples
> > left.
>
> Seems questionable for backporting to a stable release. The bogus
> PROVIDES lines have been there for more than a decade without causing
> any issues (ie removing them isn't fixing a bug).
My rationale for including this was that users often take our recipes
as templates for their own, so best we model good behavior :-)
But I don't feel strongly about it so I'll drop from my pull request.
That's what this review period is for, so thanks for taking a
thoughtful look at the patches!
Steve
> > Signed-off-by: Robert P. J. Day <rpj...@crashcourse.ca>> Signed-off-by:
> > Richard Purdie <richard.pur...@linuxfoundation.org>
> > (cherry picked from commit 6f2c9602bc5fc6794b852ec20f40ea62a55ada1e)
> > Signed-off-by: Steve Sakoman <st...@sakoman.com>
> > ---
> > meta/recipes-core/packagegroups/packagegroup-base.bb | 1 -
> > meta/recipes-core/packagegroups/packagegroup-core-nfs.bb | 1 -
> > 2 files changed, 2 deletions(-)
> >
> > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > index 1f802da09b..c32664917f 100644
> > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > @@ -8,7 +8,6 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
> >
> > inherit packagegroup
> >
> > -PROVIDES = "${PACKAGES}"
> > PACKAGES = ' \
> > packagegroup-base \
> > packagegroup-base-extended \
> > diff --git a/meta/recipes-core/packagegroups/packagegroup-core-nfs.bb
> > b/meta/recipes-core/packagegroups/packagegroup-core-nfs.bb
> > index b345e314ad..20fe6fc092 100644
> > --- a/meta/recipes-core/packagegroups/packagegroup-core-nfs.bb
> > +++ b/meta/recipes-core/packagegroups/packagegroup-core-nfs.bb
> > @@ -7,7 +7,6 @@ PR = "r2"
> >
> > inherit packagegroup
> >
> > -PROVIDES = "${PACKAGES}"
> > PACKAGES = "${PN}-server ${PN}-client"
> >
> > SUMMARY_${PN}-client = "NFS client"
> > --
> > 2.25.1
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#150172):
https://lists.openembedded.org/g/openembedded-core/message/150172
Mute This Topic: https://lists.openembedded.org/mt/81779869/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
