On 03.05.21 08:36, Khem Raj wrote:
Since these files are passed to merge_config.sh its better to use a
sorted list, so we can be sure that this list is always fed in same
order irrespective of python versions on host
Signed-off-by: Khem Raj <[email protected]>
---
meta/classes/cml1.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index d319d66ab2..1c3d70b48d 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -6,7 +6,7 @@ def find_cfgs(d):
if s.endswith('.cfg'):
sources_list.append(s)
- return sources_list
+ return sorted(sources_list)
Just as a thought, wouldn't it be better to have the ordering defined
based on recipe/layer meta data?
Previously ordering was more or less based on the inode number of the
files - now it's alphabetically.
I know that config fragments should be self containing, but seen enough
real world examples where that isn't the case, so for them this might
cause a breaking change (tbf the behavior before wasn't fully
deterministic as well)
But this issue isn't limited to this particular piece of code here and
might need some more general solution.
cml1_do_configure() {
set -e
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151186):
https://lists.openembedded.org/g/openembedded-core/message/151186
Mute This Topic: https://lists.openembedded.org/mt/82545479/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
