On Tue, 2021-05-04 at 09:31 -0400, Robert P. J. Day wrote:
> more nitpickery, but i note in OE's current bitbake.conf the
> initially odd definitions:
>
> FILES_${PN} = "${bindir}/* ${sbindir}/* ...'
> ... snip ...
>
> FILES_${PN}-bin = "${bindir}/* ${sbindir}/*"
>
> i say "odd" since someone perusing that file could be confused, first,
> that that "-bin" package definition overlaps with the base package
> file list and, more, that just above that, the definition of PACKAGES
> doesn't include the "-bin" package:
>
> PACKAGES = "${PN}-src ${PN}-dbg ${PN}-staticdev ${PN}-dev \
> ${PN}-doc ${PN}-locale ${PACKAGE_BEFORE_PN} ${PN}"
>
> so anyone currently RTFS is likely to stop and think, "what the heck
> is the '-bin' package defined for if it's not even included in the
> normal package list?"
>
> of course, one need to consult lib_package.bbclass to finally
> understand what its purpose is:
>
> PACKAGE_BEFORE_PN = "${PN}-bin"
>
> but if that's the only purpose for that package definition, would it
> not make more sense to just move it to lib_package.bbclass so it's
> next to the variable setting that actually causes it to be processed?
>
> of course it works as is, it just seems unnecessarily confusing,
> unless there's some subtle ordering requirement happening here.
I suspect such a change may break as some other recipe may use ${PN}-bin
but not the class. We'd need a careful audit to figure it out...
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151239):
https://lists.openembedded.org/g/openembedded-core/message/151239
Mute This Topic: https://lists.openembedded.org/mt/82577515/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
