On Wed, May 5, 2021 at 3:21 PM Martin Jansa <martin.ja...@gmail.com> wrote:
> It's actually from 2013, see: > > https://github.com/meta-qt5/meta-qt5/commit/671313d0b5e09e0b49a90ed944cd33fb3d6457b0 > > it had couple iterations in meta-qt5 before it was moved to oe-core in: > https://github.com/meta-qt5/meta-qt5/commit/17f240df > > http://git.openembedded.org/openembedded-core/commit/?h=daisy&id=4f2dee0d8c2c3f60cb8f8021343e973cae31fc50 > as bunch of sed calls which were later changed to a .patch in 2018 > > http://git.openembedded.org/openembedded-core/commit/?id=9e58926f1cea9d5cb18cb923855d1ae98f88a8ac > > Now with RSS this shouldn't be so big issue, that rebuilding cmake-native > after qtbase-native won't suddenly detect Qt support for CMake, but it > should be tested on host with Qt5 installed to make sure it's not detected > from host and stays explicitly disabled (maybe there is a flag for that > nowadays - I didn't check in last 8 years :)). > Thanks for the context Martin I think host intrusion is a valid point although perhaps less of a chance > On Wed, May 5, 2021 at 10:52 PM Otavio Salvador < > otavio.salva...@ossystems.com.br> wrote: > >> Hello, >> >> Em qua., 5 de mai. de 2021 às 15:35, Khem Raj <raj.k...@gmail.com> >> escreveu: >> > >> > before we remove it, lets hear a Review from Otavio and perhaps he has >> > better history with this patch >> > >> > On Wed, May 5, 2021 at 8:19 AM Alexander Kanavin < >> alex.kana...@gmail.com> wrote: >> > > >> > > Remove 0002-cmake-Prevent-the-detection-of-Qt5.patch >> > > (patch purpose and failing scenarios unclear; disabling >> > > is better done through configuration options which >> > > are available for all of these items). >> >> Try build it on a host with Qt to see if it fails. This is what comes >> to my mind. I don't recall the details as it was done in 2018 ... >> gosh, I am getting old. >> >> -- >> Otavio Salvador O.S. Systems >> http://www.ossystems.com.br http://code.ossystems.com.br >> Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750 >> >> >> >>
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#151370): https://lists.openembedded.org/g/openembedded-core/message/151370 Mute This Topic: https://lists.openembedded.org/mt/82607021/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
