Hi Quentin, Thanks for the review!
On 5/6/21 11:25 AM, Quentin Schulz wrote: > Hi Michael, > > On Wed, May 05, 2021 at 07:56:15PM +0200, Michael Opdenacker wrote: >> This expands the error message when a network failure is detected. >> It happens that some ISPs or networks block the default example.com >> domain. Therefore, instead of disabling network access, it >> lets the user know how to modify the test URL. >> >> Signed-off-by: Michael Opdenacker <[email protected]> >> --- >> meta/classes/sanity.bbclass | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass >> index a377917f2a..e907a3566f 100644 >> --- a/meta/classes/sanity.bbclass >> +++ b/meta/classes/sanity.bbclass >> @@ -392,9 +392,12 @@ def check_connectivity(d): >> msg = data.getVar('CONNECTIVITY_CHECK_MSG') or "" >> if len(msg) == 0: >> msg = "%s.\n" % err >> - msg += " Please ensure your host's network is configured >> correctly,\n" >> - msg += " or set BB_NO_NETWORK = \"1\" to disable network >> access if\n" >> - msg += " all required sources are on local disk.\n" >> + msg += " Please ensure your host's network is configured >> correctly.\n" >> + msg += " If your ISP or network is blocking the above >> URL,\n" >> + msg += " try with another domain name, for example by >> setting:\n" >> + msg += " CONNECTIVITY_CHECK_URIS = >> \"https://www.yoctoproject.org/\""; >> + msg += " You could also set BB_NO_NETWORK = \"1\" to >> disable network\n" >> + msg += " access if all required sources are on local >> disk.\n" > I have my doubts that we want to explicit all ways to get rid of the > message. I'd see more an indication to look at the documentation for > this.... and since I wanted to check what we had in the docs for > CONNECTIVITY_CHECK_URIS I discovered we don't have anything for > that variable in YP documentation! > > That would be a nice addition even if you keep the message as is! Sure, I was definitely planning to add such documentation. Any other thoughts about making this error message more helpful? Cheers, Michael. -- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#151387): https://lists.openembedded.org/g/openembedded-core/message/151387 Mute This Topic: https://lists.openembedded.org/mt/82611501/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
