Thanks, it would be beneficial to record this information in the commit message.
Alex On Tue, 25 May 2021 at 13:27, Samuli Piippo <[email protected]> wrote: > Issue came up while building Qt6, which uses cmake packaging API: > https://gitlab.kitware.com/cmake/cmake/-/issues/21552 > Things break when zstd support is not available and CMake doesn't provide > simple why to ask if the support is available. > > Quote from cmake dev: > As far as CMake's design is concerned, we have no optional formats. All > should be supported. > That's why we bundle sufficiently new versions of libarchive and libzstd. > If a distro builds with an older libarchive that doesn't have zstd > support, then that is not a proper packaging of CMake. > > For target/nativesdk CMake depends on libarchive for this support, which > is covered in the second patch. > > -samuli > > On Tue, 25 May 2021 at 13:07, Alexander Kanavin <[email protected]> > wrote: > >> You need to explain the benefit in doing so, I think? :) >> >> Alex >> >> On Tue, 25 May 2021 at 12:05, Samuli Piippo <[email protected]> >> wrote: >> >>> Now that zstd is in oe-core, enable support for it in native CMake. >>> >>> Signed-off-by: Samuli Piippo <[email protected]> >>> --- >>> meta/recipes-devtools/cmake/cmake-native_3.20.1.bb | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-devtools/cmake/cmake-native_3.20.1.bb >>> b/meta/recipes-devtools/cmake/cmake-native_3.20.1.bb >>> index d91e42ef9a..335097d387 100644 >>> --- a/meta/recipes-devtools/cmake/cmake-native_3.20.1.bb >>> +++ b/meta/recipes-devtools/cmake/cmake-native_3.20.1.bb >>> @@ -1,7 +1,7 @@ >>> require cmake.inc >>> inherit native >>> >>> -DEPENDS += "bzip2-replacement-native xz-native zlib-native curl-native >>> ncurses-native" >>> +DEPENDS += "bzip2-replacement-native xz-native zlib-native curl-native >>> ncurses-native zstd-native" >>> >>> SRC_URI += "file://OEToolchainConfig.cmake \ >>> file://environment.d-cmake.sh \ >>> -- >>> 2.25.1 >>> >>> >>> >>> >>>
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#152221): https://lists.openembedded.org/g/openembedded-core/message/152221 Mute This Topic: https://lists.openembedded.org/mt/83072435/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
