The routine do_sizecheck() was historically needed by legacy
devices with limited flash memory.
The lowest extreme is probably with Zaurus collie having exactly
1024*1024 = 1048576 bytes for the kernel partition.

In the years the KERNEL_IMAGE_MAXSIZE has been converted to kilobytes
thus rounded so we have now KERNEL_IMAGE_MAXSIZE_collie = "1024".

The effect is that now the check fails because we hit curiously this
 | WARNING: This kernel zImage (size=1024(K) > 1024(K)) is too big for...
even though zImage is 1047288 bytes (kernel + kexecboot-klibc-initramfs).

Fix this case using test -gt (greater) instead of -ge (greater or equal).

Signed-off-by: Andrea Adami <[email protected]>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 8693ab86be..379bed44f2 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -714,7 +714,7 @@ do_sizecheck() {
                at_least_one_fits=
                for imageType in ${KERNEL_IMAGETYPES} ; do
                        size=`du -ks ${B}/${KERNEL_OUTPUT_DIR}/$imageType | awk 
'{print $1}'`
-                       if [ $size -ge ${KERNEL_IMAGE_MAXSIZE} ]; then
+                       if [ $size -gt ${KERNEL_IMAGE_MAXSIZE} ]; then
                                bbwarn "This kernel $imageType (size=$size(K) > 
${KERNEL_IMAGE_MAXSIZE}(K)) is too big for your device."
                        else
                                at_least_one_fits=y
-- 
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#152881): 
https://lists.openembedded.org/g/openembedded-core/message/152881
Mute This Topic: https://lists.openembedded.org/mt/83499050/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to