On Mon, 21 Jun 2021 at 19:30, Tim Orling <ticot...@gmail.com> wrote: > > > On Mon, Jun 21, 2021 at 5:00 AM Alexander Kanavin <alex.kana...@gmail.com> > wrote: > >> Wait. How does this work, if IMAGE_FEATURES are set from image recipes, >> and not globally? >> >> I'm afraid this may have to be reverted, as it just made it to master. >> >> > These tests have only been passing (since.python3 3.9.0 upgrade) because > the AB ptest images in one way or another have included > packagegroup-core-buildessential. > > I asked RP about adding packagegroup-core-buildessential as RDEPENDS for > python3-ptest and he was concerned about build performance. I tried to > narrow the scope to gcc-symlinks and binutils-symlinks, but that was not > enough to make the tests pass. > > As I see it, we have two options, this patch which skips the tests > conditionally, or we UNCONDITIONALLY skip the tests. > If you run python3-ptest (and nothing else) on core-image-minimal, these > test cases will fail, which means we do not have proper RDEPENDS for > python3-ptest. >
I think the right way out of this is to modify the tests so that they check for the presence of items that are used by the tests and skip themselfes if those items (gcc, etc) are not present (turn a hard dependency into a soft one). Then simply apply the patch without any conditions in the recipe. There are many other tests which self-skip in a similar way already, we do not necessarily maintain the full soft dependency set for the fullest ptest coverage, not should we try to. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#153157): https://lists.openembedded.org/g/openembedded-core/message/153157 Mute This Topic: https://lists.openembedded.org/mt/83641452/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
