Frankly guys, I think maybe we should just break stuff in this case, and have it fixed up properly, then try to guess what workaround might work.
>From that perspective the original patch is the most clear. Alex On Wed, 23 Jun 2021 at 11:26, Peter Kjellerstedt < [email protected]> wrote: > I suggest you use =+ instead of _prepend to maintain expansion order. > I.e., if someone does: > > > > inherit pypi > > > > SRC_URI = "http://some_url ${PYPI_SRC_URI}" > > > > However, any way you change it, you risk breaking someone’s use case, but > I believe using =+ instead of += should be the least invasive change > compared to the current version. > > > > //Peter > > > > *From:* [email protected] < > [email protected]> *On Behalf Of *Alexander Kanavin > *Sent:* den 23 juni 2021 10:34 > *To:* Konrad Weihmann <[email protected]> > *Cc:* OE-core <[email protected]> > *Subject:* Re: [OE-core] [PATCH] pypi: set SRC_URI with =, not with += > > > > Right, I sent an updated patch. > > > > Alex > > > > On Wed, 23 Jun 2021 at 09:01, Konrad Weihmann <[email protected]> > wrote: > > That doesn't look completely right to me. > > You're absolutely right about devtool expecting the tarball in as the 1st > item, but this patch here breaks existing recipes like > > SRC_URI += "file://some.patch" > > inherit pypi > > as the patch will now be dropped. > > > > I would suggest to go for SRC_URI_prepend = "${PYPI_SRC_URI} " which fixes > the issue *and* doesn't break exisiting setups > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#153234): https://lists.openembedded.org/g/openembedded-core/message/153234 Mute This Topic: https://lists.openembedded.org/mt/83721889/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
