Hello Peter,
On Wed, Aug 25, 2021 at 3:21 PM Peter Kjellerstedt
<[email protected]> wrote:
>
> Makefile-Do-not-fail-if-CONFIG_TRACEPOINTS-is-not-en.patch was updated
> with the 2.13.0 update (commit 5dad15af), but unfortunately it no
> longer did what it was intended to do. There is also
> 0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch, which
> was based on the former patch, but it too does not solve the problem.
>
> Unify the two patches, and actually disable building of the kernel
> module if CONFIG_TRACEPOINTS is not enabled, the way it was intended.
>
> Signed-off-by: Peter Kjellerstedt <[email protected]>
> ---
>
> PATCHv2: Unify
> Makefile-Do-not-fail-if-CONFIG_TRACEPOINTS-is-not-en.patch and
> 0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch into
> the latter, and use that both with and without devupstream.
I've tried the patch on my end, but it seems as if it does not resolve
the build issue entirely.
Compile stage is skipped with the message:
"lttng-modules-2.13.0/src/Kbuild:5: The option CONFIG_TRACEPOINTS
needs to be enabled in your kernel configuration"
which is totally fine.
However, the install fails due to the do_install:append in recipe
contains following:
do_install:append() {
# Delete empty directories to avoid QA failures if no modules were built
find ${D}/${nonarch_base_libdir} -depth -type d -empty -exec rmdir {} \;
}
Since there was no module produced by do_compile() -
${D}/${nonarch_base_libdir} is non-existent, and find fails.
I was wondering if you've seen the same build failure on your end?
Also, if I explicitly check for folder existence like following:
do_install:append() {
# Delete empty directories to avoid QA failures if no modules were built
if [ -d ${D}/${nonarch_base_libdir} ]; then
find ${D}/${nonarch_base_libdir} -depth -type d -empty
-exec rmdir {} \;
fi
}
then package is built fine.
Wonder if you would want to apply it in your patch set?
>
> ...e-missing-CONFIG_TRACEPOINTS-to-warn.patch | 25 +++++++++----
> ...fail-if-CONFIG_TRACEPOINTS-is-not-en.patch | 37 -------------------
> .../lttng/lttng-modules_2.13.0.bb | 10 ++---
> 3 files changed, 21 insertions(+), 51 deletions(-)
> delete mode 100644
> meta/recipes-kernel/lttng/lttng-modules/Makefile-Do-not-fail-if-CONFIG_TRACEPOINTS-is-not-en.patch
>
--
Regards,
Andrey.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#155302):
https://lists.openembedded.org/g/openembedded-core/message/155302
Mute This Topic: https://lists.openembedded.org/mt/85135221/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
