On Fri, 10 Sept 2021 at 09:08, Robert Yang <[email protected]> wrote:
> - self._run("cd {build} && cmake -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON
> {source}".format(**dirs))
> + self._run("cd {build} && cmake {source}".format(**dirs))
Verbose makefiles were turned on for a reason: when it breaks, we want
to see the full log.
> self._run("cmake --build {build} -- -j".format(**dirs))
> self._run("cmake --build {build} --target install --
> DESTDIR={install}".format(**dirs))
> - self.check_elf(os.path.join(dirs["install"], "usr", "local",
> "lib", "libassimp.so.4.1.0"))
> + self.check_elf(os.path.join(dirs["install"],
> "usr/local/lib/libexpat.so.1.8.1"))
Using join() but passing a hardcoded path string seems suboptimal.
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#155903):
https://lists.openembedded.org/g/openembedded-core/message/155903
Mute This Topic: https://lists.openembedded.org/mt/85504678/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
