On Tue, Oct 26, 2021 at 4:11 AM Richard Purdie <[email protected]> wrote: > > This patch looks obsolete because it looks like part of an upstream > backport on a very old gcc version (4.3.3) and looks incomplete. The > diff also has little context making it likely to be a rebase error. > > Builds seem find without it so drop it. >
IIRC it was not accepted upstream but perhaps a different one was. However if it builds for us without issues then drop it. > Signed-off-by: Richard Purdie <[email protected]> > --- > meta/recipes-devtools/gcc/gcc-11.2.inc | 1 - > ...-gcc-4.3.3-SYSROOT_CFLAGS_FOR_TARGET.patch | 70 ------------------- > 2 files changed, 71 deletions(-) > delete mode 100644 > meta/recipes-devtools/gcc/gcc/0003-gcc-4.3.3-SYSROOT_CFLAGS_FOR_TARGET.patch > > diff --git a/meta/recipes-devtools/gcc/gcc-11.2.inc > b/meta/recipes-devtools/gcc/gcc-11.2.inc > index 1ab779533ca..23dfea2319e 100644 > --- a/meta/recipes-devtools/gcc/gcc-11.2.inc > +++ b/meta/recipes-devtools/gcc/gcc-11.2.inc > @@ -32,7 +32,6 @@ SRC_URI = "\ > ${BASEURI} \ > file://0001-gcc-4.3.1-ARCH_FLAGS_FOR_TARGET.patch \ > file://0002-gcc-poison-system-directories.patch \ > - file://0003-gcc-4.3.3-SYSROOT_CFLAGS_FOR_TARGET.patch \ > file://0004-64-bit-multilib-hack.patch \ > file://0005-optional-libstdc.patch \ > file://0006-COLLECT_GCC_OPTIONS.patch \ > diff --git > a/meta/recipes-devtools/gcc/gcc/0003-gcc-4.3.3-SYSROOT_CFLAGS_FOR_TARGET.patch > > b/meta/recipes-devtools/gcc/gcc/0003-gcc-4.3.3-SYSROOT_CFLAGS_FOR_TARGET.patch > deleted file mode 100644 > index 7a676545557..00000000000 > --- > a/meta/recipes-devtools/gcc/gcc/0003-gcc-4.3.3-SYSROOT_CFLAGS_FOR_TARGET.patch > +++ /dev/null > @@ -1,70 +0,0 @@ > -From 274a27da6fe355c4c49953b3b69c8949d2412c62 Mon Sep 17 00:00:00 2001 > -From: Khem Raj <[email protected]> > -Date: Fri, 29 Mar 2013 09:08:31 +0400 > -Subject: [PATCH] gcc-4.3.3: SYSROOT_CFLAGS_FOR_TARGET > - > -Before committing, I noticed that PR/32161 was marked as a dup of PR/32009, > but my previous patch did not fix it. > - > -This alternative patch is better because it lets you just use > CFLAGS_FOR_TARGET to set the compilation flags for libgcc. Since bootstrapped > target libraries are never compiled with the native compiler, it makes little > sense to use different flags for stage1 and later stages. And it also makes > little sense to use a different variable than CFLAGS_FOR_TARGET. > - > -Other changes I had to do include: > - > -- moving the creation of default CFLAGS_FOR_TARGET from Makefile.am to > configure.ac, because otherwise the BOOT_CFLAGS are substituted into > CFLAGS_FOR_TARGET (which is "-O2 -g $(CFLAGS)") via $(CFLAGS). It is also > cleaner this way though. > - > -- passing the right CFLAGS to configure scripts as exported environment > variables > - > -I also stopped passing LIBCFLAGS to configure scripts since they are unused > in the whole src tree. And I updated the documentation as H-P reminded me to > do. > - > -Bootstrapped/regtested i686-pc-linux-gnu, will commit to 4.4 shortly. Ok for > 4.3? > - > -Signed-off-by: Paolo Bonzini <[email protected]> > -Signed-off-by: Khem Raj <[email protected]> > - > -Upstream-Status: Pending > ---- > - configure | 32 ++++++++++++++++++++++++++++++++ > - 1 file changed, 32 insertions(+) > - > -diff --git a/configure b/configure > -index bcebad264ec..86e4ee7c383 100755 > ---- a/configure > -+++ b/configure > -@@ -8977,6 +8977,38 @@ fi > - > - > - > -+# During gcc bootstrap, if we use some random cc for stage1 then CFLAGS > -+# might be empty or "-g". We don't require a C++ compiler, so CXXFLAGS > -+# might also be empty (or "-g", if a non-GCC C++ compiler is in the path). > -+# We want to ensure that TARGET libraries (which we know are built with > -+# gcc) are built with "-O2 -g", so include those options when setting > -+# CFLAGS_FOR_TARGET and CXXFLAGS_FOR_TARGET. > -+if test "x$CFLAGS_FOR_TARGET" = x; then > -+ CFLAGS_FOR_TARGET=$CFLAGS > -+ case " $CFLAGS " in > -+ *" -O2 "*) ;; > -+ *) CFLAGS_FOR_TARGET="-O2 $CFLAGS" ;; > -+ esac > -+ case " $CFLAGS " in > -+ *" -g "* | *" -g3 "*) ;; > -+ *) CFLAGS_FOR_TARGET="-g $CFLAGS" ;; > -+ esac > -+fi > -+ > -+ > -+if test "x$CXXFLAGS_FOR_TARGET" = x; then > -+ CXXFLAGS_FOR_TARGET=$CXXFLAGS > -+ case " $CXXFLAGS " in > -+ *" -O2 "*) ;; > -+ *) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS" ;; > -+ esac > -+ case " $CXXFLAGS " in > -+ *" -g "* | *" -g3 "*) ;; > -+ *) CXXFLAGS_FOR_TARGET="-g $CXXFLAGS" ;; > -+ esac > -+fi > -+ > -+ > - # Handle --with-headers=XXX. If the value is not "yes", the contents of > - # the named directory are copied to $(tooldir)/sys-include. > - if test x"${with_headers}" != x && test x"${with_headers}" != xno ; then > -- > 2.32.0 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#157402): https://lists.openembedded.org/g/openembedded-core/message/157402 Mute This Topic: https://lists.openembedded.org/mt/86599750/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
