> -----Original Message----- > From: Richard Purdie <[email protected]> > Sent: den 11 november 2021 11:31 > To: Peter Kjellerstedt <[email protected]>; Mittal, Anuj > <[email protected]> > Cc: OE Core ([email protected]) <openembedded- > [email protected]> > Subject: Re: [OE-core] [honister][PATCH] insane.bbclass: Add a check for > directories that are expected to be empty > > On Thu, 2021-11-11 at 09:42 +0000, Peter Kjellerstedt wrote: > > > -----Original Message----- > > > From: Mittal, Anuj <[email protected]> > > > Sent: den 11 november 2021 04:06 > > > To: Peter Kjellerstedt <[email protected]> > > > Subject: Re: [OE-core] [honister][PATCH] insane.bbclass: Add a check > for > > > directories that are expected to be empty > > > > > > On Wed, 2021-11-10 at 20:53 +0000, Peter Kjellerstedt wrote: > > > > > -----Original Message----- > > > > > From: [email protected] <openembedded- > > > > > [email protected]> On Behalf Of Anuj Mittal > > > > > Sent: den 9 november 2021 15:36 > > > > > To: [email protected]; Peter Kjellerstedt > > > > > <[email protected]> > > > > > Subject: Re: [OE-core] [honister][PATCH] insane.bbclass: Add a > > > > > check for > > > > > directories that are expected to be empty > > > > > > > > > > On Mon, 2021-11-08 at 18:10 +0100, Peter Kjellerstedt wrote: > > > > > > From: Peter Kjellerstedt <[email protected]> > > > > > > > > > > > > The empty-dirs QA check verifies that all directories specified > > > > > > in > > > > > > QA_EMPTY_DIRS are empty. It is possible to specify why a > > > > > > directory is > > > > > > expected to be empty by defining > > > > > > QA_EMPTY_DIRS_RECOMMENDATION:<path>, > > > > > > which will then be included in the error message if the > directory > > > > > > is > > > > > > not empty. If it is not specified for a directory, then "but it > > > > > > is > > > > > > expected to be empty" will be used. > > > > > > > > > > > > Change-Id: Ic61019528f4b22f26e42e78125a99666ae27c7f5 > > > > > > Signed-off-by: Peter Kjellerstedt <[email protected]> > > > > > > --- > > > > > > > > > > > > Compared to the corresponding patch for master, there are two > > > > > > differences: > > > > > > > > > > > > * "/var/volatile" is not added to QA_EMPTY_DIRS by default. > > > > > > * "empty-dirs" is added to WARN_QA instead of ERROR_QA. > > > > > > > > > > > > This should make it safe to add this QA test to Honister without > > > > > > introdusing any new QA errors, while still allowing the QA test > to be > > > > > > activated for those who wants to use it. > > > > > > > > > > Does it have to be enabled by default? > > > > > > > > Well, it doesn't have to be enabled. However, without /var/volatile > in > > > > QA_EMPTY_DIRS, there should be no warnings generated for OE-Core or > > > > OpenEmbedded so it should not hurt to have it in WARN_QA. > > > > > > Right, but there could be unexpected warnings for other downstream > > > layers in release versions. > > > > True, but they would still just be warnings. > > In the context of backports, this needs to be handled carefully. You're > effectively asking for new feature backport here and people aren't happy > when stable branches suddenly show new warnings. > > If the issue was of huge importance, that would be ok but I'm not sure > that is the case here, we've managed with the code as is for a long time. > > Cheers, > > Richard
Sure, I'm perfectly fine with the feature being backported without it being enabled out-of-the-box as it will still allow me to remove our local solution for the same problem. //Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#158166): https://lists.openembedded.org/g/openembedded-core/message/158166 Mute This Topic: https://lists.openembedded.org/mt/86910911/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
