Saul Wold wrote on 2012-01-19:
>> +    if [ "${NOVMDK}" != "1" ] ; then
> Why make this a "double negative", Why not have a CREATE_VMDK check?
> 
>> +            ${STAGING_BINDIR_NATIVE}/qemu-img convert -O vmdk   \
>> +                    ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.hdddirect \
>> +                    ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.vmdk
>> +    fi
>>   }
Hi Saul,
I thought it's better to create .vmdk by default.
So do you think this is better?
if [ "${CREATE_VMDK}" == "1" ] ; then
  #create the .vmdk image.
fi

In this way we don't create .vmdk by default and I'll define
CREATE_VMDK = "1"
in self-hosted-image.bb to generate the .vmdk.

Thanks,
-- Dexuan



_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to