Am 24.11.2021 um 15:58 schrieb Konrad Weihmann:
On 24.11.21 15:47, Stefan Herbrechtsmeier wrote:
From: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com>

Created via recipetool:
   devtool add --npm-dev node-red-src https://github.com/node-red/node-red.git

Requires openssh-native as DEPENDS to pass all unit tests.

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com>
---

  .../node-red/node-red-src_git.bb              | 2855 +++++++++++++++++
  1 file changed, 2855 insertions(+)
  create mode 100644 meta/recipes-devtools/node-red/node-red-src_git.bb

diff --git a/meta/recipes-devtools/node-red/node-red-src_git.bb b/meta/recipes-devtools/node-red/node-red-src_git.bb
new file mode 100644
index 0000000000..a2e2d9aff1
--- /dev/null
+++ b/meta/recipes-devtools/node-red/node-red-src_git.bb
@@ -0,0 +1,2855 @@
+# Recipe created by recipetool
+# This is the basis of a recipe and may need further editing in order to be fully functional.
+# (Feel free to remove these comments when editing.)

I assume that could be removed
The intendion of this file is to demonstrated the output of the recipetool and not for integration into a layer.


+
+SUMMARY = "Low-code programming for event-driven applications"
+HOMEPAGE = "http://nodered.org";
+# WARNING: the following LICENSE and LIC_FILES_CHKSUM values are best guesses - it is +# your responsibility to verify that the values are complete and correct.
+#
+# NOTE: multiple licenses have been detected; they have been separated with & +# in the LICENSE value for now since it is a reasonable assumption that all +# of the licenses apply. If instead there is a choice between the multiple +# licenses then you should change the value to separate the licenses with | +# instead of &. If there is any doubt, check the accompanying documentation
+# to determine which situation is applicable.

Same for this comment

See above.


+LICENSE = "Apache-2.0 & MIT & BSD-3-Clause & ISC & ISC & MIT & Unlicense &  MIT & BSD-2-Clause & Apache-2.0 | MPL-2.0 & BSD-0-Clause & MIT & BSD-3-Clause & CC0-1.0 & MIT & Python-2.0 & Apache-2.0 & MIT & ISC & CC-BY-SA-4.0 & Apache-2.0 & Unlicense & BSD-3-Clause & MIT & BSD-3-Clause & MPL-2.0 & ISC | MIT & WTFPL"

I truly believe that needs some brackets to improve readability (and I'm even not sure if it does compute correctly).

You are right. The old code needs some rework for the license generation.

+LIC_FILES_CHKSUM = "file://LICENSE;md5=014f1a23c3da49aa929b21a96808ab22 \ +

[snip]

+DEPENDS = "openssh-native"
+
+SRC_URI = " \
+ git://github.com/node-red/node-red.git;protocol=https;branch=master;name=main \ + git://g...@github.com/node-red/jsdoc-nr-template.git;destsuffix=git/node_modules/jsdoc-nr-template;nobranch=1;protocol=ssh;rev=3c7c8f96d585c7c5918a2e63519310e1297e162d \

IIRC ssh will be discontinued by github, so I'd say it should use https if possible

This protocol is resolved by npm from package.json to npm-shrinkwrap.json:
github: --> git+ssh://g...@github.com/

I will replace it with https in the create_npm.py.

[snip]

https://registry.npmjs.org/zip-stream/-/zip-stream-4.1.0.tgz;downloadfilename=npm2/zip-stream-4.1.0.tgz;sha512sum=cec873c105bb806ee18e906581e40ff51bb23c6371bc977347c494337421c429cb8d637613b8f774ebe9783710a044df1f1d2ead14bb12d9954e8aa5ed8a54e0;subdir=git/node_modules/zip-stream;striplevel=1 \
+    "

To be honest - this recipe is almost impossible to read - is there a way to split that up in reasonable chunks?

What are reasonable chunks?

It is possible to replace the URL with a python script or npm fetcher:

npm_package(zip-stream, 4.1.0);sha512sum=cec873c105bb806ee18e906581e40ff51bb23c6371bc977347c494337421c429cb8d637613b8f774ebe9783710a044df1f1d2ead14bb12d9954e8aa5ed8a54e0;subdir=git/node_modules/zip-stream

Furthermore the sha512sum could be moved to SRC_URI[zip-stream-4.1.0.sha512sum].


+# Modify these as desired
+PV = "2.1.3+git${SRCPV}"
+SRCREV_FORMAT = "main"
+SRCREV_main = "9439cd0e3d57ad103cef28618783f0d609441dbc"
+
+S = "${WORKDIR}/git"
+
+inherit npm_test
+
+LICENSE:${PN} = "BSD-3-Clause Apache-2.0 MIT"

I'm missing a few & in the SPDX string in case there are multiple licences by package

I will check why there are no & or |.

[snip]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#158724): 
https://lists.openembedded.org/g/openembedded-core/message/158724
Mute This Topic: https://lists.openembedded.org/mt/87282292/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to