On 1/5/22 23:40, Steve Sakoman wrote:
On Wed, Jan 5, 2022 at 12:25 PM Marek Vasut <[email protected]> wrote:

On 1/5/22 23:21, Marek Vasut wrote:
In case the device has only touchscreen input device and no keyboard or mouse,
the top level surface is never activated. The behavior differs from a device
which has a keyboard (or gpio-keys, or even uinput-emulated keyboard), where
callchain activate()->weston_view_activate()->weston_seat_set_keyboard_focus()->
weston_keyboard_set_focus()->wl_signal_emit(&keyboard->focus_signal, keyboard)->
handle_keyboard_focus()->weston_desktop_surface_set_activated(..., true); sets
the top level surface as activated. On device with touchscreen, the above is
never called, hence the top level surface is never activated. Add explicit
weston_desktop_surface_set_activated(shsurf->desktop_surface, true); into
activate() to always active the top level surface.

This fixes at least two known issues on such devices:
- Wayland terminal cursor is an empty bar (full bar with keyboard present)
- Chromium dropdown menus are randomly placed (they are placed correctly
    when keyboard is present, because then chromium can find the activated
    top level surface)

Signed-off-by: Marek Vasut <[email protected]>
Cc: Steve Sakoman <[email protected]>

And that Subject should've had [dunfell] tag, sorry.
Do you need a resend ?

No, I've got it!

Thanks,

Thanks
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160218): 
https://lists.openembedded.org/g/openembedded-core/message/160218
Mute This Topic: https://lists.openembedded.org/mt/88225658/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to