On Sat, Jan 15, 2022 at 02:53:09AM +0000, Mittal, Anuj wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Sat, 2022-01-15 at 10:37 +0800, Kevin Hao wrote: > > From: Jagadeesh Krishnanjanappa <workjagade...@gmail.com> > > > > The cryptographic unit is optional for the Cortex-A72, but it was > > included by default previously. This breaks building systems that > > lack this functionality when using tune-cortexa72.inc. > > > > To correct this, add a crypto entry in the tune file. Since CRC is > > optional for ARMv8.0, do the same thing while we're at it. > > > > For platforms that had been happily using tune-cortexa72.inc, a > > slight > > degradation of performance will occur using the default. To correct > > this, simply add: > > DEFAULTTUNE = "cortexa72-crc-crypto" > > > > I am not very familiar with ARM tunes but it sounds like you are > changing behaviour for people who might already be using these tunes > with these two patches ... That might not be suitable for stable > branches.
These two patches fix the application crash bug on the boards which
have a cortexa72 core but don't have a crypto unit. IMHO they are definitely
suitable for the stable branch. Yes, for the boards which do have a crypto
unit, they would have to update their default tune to avoid the slight
the degradation of performance.
Thanks,
Kevin
>
> Perhaps Ross, Jon or others can comment if this is something that
> should be merged in stable branches.
>
> Thanks,
>
> Anuj
>
> > (From OE-Core rev: 2568d537087adb0b592aa250bf628a7b48c3a9d3)
> >
> > Signed-off-by: Jagadeesh Krishnanjanappa <workjagade...@gmail.com>
> > Signed-off-by: Jon Mason <jdma...@kudzu.us> (rewording commit
> > message)
> > Signed-off-by: Richard Purdie <richard.pur...@linuxfoundation.org>
> > [Kevin: Convert to the old style override syntax]
> > Signed-off-by: Kevin Hao <kexin....@windriver.com>
> > ---
> > meta/conf/machine/include/tune-cortexa72.inc | 16 ++++++++++++----
> > 1 file changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta/conf/machine/include/tune-cortexa72.inc
> > b/meta/conf/machine/include/tune-cortexa72.inc
> > index b3f68ab6e3be..7608a20c43f4 100644
> > --- a/meta/conf/machine/include/tune-cortexa72.inc
> > +++ b/meta/conf/machine/include/tune-cortexa72.inc
> > @@ -6,8 +6,16 @@ TUNE_CCARGS .=
> > "${@bb.utils.contains('TUNE_FEATURES', 'cortexa72', ' -mcpu=corte
> > require conf/machine/include/arm/arch-armv8a.inc
> >
> > # Little Endian base configs
> > -AVAILTUNES += "cortexa72"
> > +AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto"
> > ARMPKGARCH_tune-cortexa72 = "cortexa72"
> > -TUNE_FEATURES_tune-cortexa72 = "${TUNE_FEATURES_tune-
> > armv8a-crc-crypto} cortexa72"
> > -PACKAGE_EXTRA_ARCHS_tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS_tune-
> > armv8a-crc-crypto} cortexa72"
> > -BASE_LIB_tune-cortexa72 = "lib64"
> > +ARMPKGARCH_tune-cortexa72-crc = "cortexa72"
> > +ARMPKGARCH_tune-cortexa72-crc-crypto = "cortexa72"
> > +TUNE_FEATURES_tune-cortexa72 = "${TUNE_FEATURES_tune-
> > armv8a} cortexa72"
> > +TUNE_FEATURES_tune-cortexa72-crc = "${TUNE_FEATURES_tune-
> > cortexa72} crc"
> > +TUNE_FEATURES_tune-cortexa72-crc-crypto = "${TUNE_FEATURES_tune-
> > cortexa72} crc crypto"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72 =
> > "${PACKAGE_EXTRA_ARCHS_tune-armv8} cortexa72"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc =
> > "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72 cortexa72-crc"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc-crypto =
> > "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72 cortexa72-
> > crc cortexa72-crc-crypto"
> > +BASE_LIB_tune-cortexa72 = "lib64"
> > +BASE_LIB_tune-cortexa72-crc = "lib64"
> > +BASE_LIB_tune-cortexa72-crc-crypto = "lib64"
>
signature.asc
Description: PGP signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#160601): https://lists.openembedded.org/g/openembedded-core/message/160601 Mute This Topic: https://lists.openembedded.org/mt/88436676/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
