Right, but this might be fixing the symptom, and not the problem. Alex
On Wed, 9 Feb 2022 at 11:53, Böszörményi Zoltán <[email protected]> wrote: > > (Resending from the address I am subscribed with.) > > I have no idea. > > It was working a week ago for me but today after "repo sync" > the image build failed on me with the quoted error. > > With this fix, the image is built with the expected contents. > > The change with "if val.startswith()" was from 2017, > something around it must have changed very recently. > > Zoltán > > 2022. 02. 09. 11:35 keltezéssel, Alexander Kanavin írta: > > Wait, why val is none in the first place? Why aren't others seeing it? > > > > Alex > > > > On Wed, 9 Feb 2022 at 10:53, Zoltan Boszormenyi via > > lists.openembedded.org <[email protected]> wrote: > >> > >> From: Zoltán Böszörményi <[email protected]> > >> > >> I got this error on current master: > >> > >> File: 'exec_func_python() autogenerated', lineno: 2, function: <module> > >> 0001: > >> *** 0002:do_write_qemuboot_conf(d) > >> 0003: > >> File: '.../layers/openembedded-core/meta/classes/qemuboot.bbclass', > >> lineno: 141, function: do_write_qemuboot_conf > >> 0137: else: > >> 0138: val = d.getVar(k) > >> 0139: # we only want to write out relative paths so that we > >> can relocate images > >> 0140: # and still run them > >> *** 0141: if val.startswith(topdir): > >> 0142: val = os.path.relpath(val, finalpath) > >> 0143: cf.set('config_bsp', k, '%s' % val) > >> 0144: > >> 0145: # QB_DEFAULT_KERNEL's value of KERNEL_IMAGETYPE is the name > >> of a symlink > >> Exception: AttributeError: 'NoneType' object has no attribute 'startswith' > >> > >> Do nothing if "val" is None. > >> > >> Signed-off-by: Zoltán Böszörményi <[email protected]> > >> --- > >> meta/classes/qemuboot.bbclass | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/meta/classes/qemuboot.bbclass b/meta/classes/qemuboot.bbclass > >> index 229bd88527..755d49acd6 100644 > >> --- a/meta/classes/qemuboot.bbclass > >> +++ b/meta/classes/qemuboot.bbclass > >> @@ -136,6 +136,8 @@ python do_write_qemuboot_conf() { > >> > >> 'qemu-helper-native/1.0-r1/recipe-sysroot-native/usr/bin/') > >> else: > >> val = d.getVar(k) > >> + if val is None: > >> + continue > >> # we only want to write out relative paths so that we can > >> relocate images > >> # and still run them > >> if val.startswith(topdir): > >> -- > >> 2.34.1 > >> > >> > >> > >> >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#161551): https://lists.openembedded.org/g/openembedded-core/message/161551 Mute This Topic: https://lists.openembedded.org/mt/89018458/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
