On Tue, Mar 1, 2022 at 4:23 PM Richard Purdie
<[email protected]> wrote:
>
> On Mon, 2022-02-28 at 12:32 +0200, Alexandru Ardelean wrote:
> > On Thu, Feb 24, 2022 at 5:30 PM Alexandru Ardelean
> > <[email protected]> wrote:
> > >
> > > It seems that the homepage has moved (for a while now) from
> > >   http://www.mega-nerd.com/libsndfile/
> > > to
> > >   https://libsndfile.github.io/libsndfile/
> > >
> > > On Github, the development group seems to include Erik de Castro Lopo (the
> > > original author of libsndfile1).
> > > Link: https://github.com/orgs/libsndfile/people
> > >
> > > All backported CVE patches are in version 1.0.31 (I've checked).
> > >
> > > The supported format page [1], mentions that Ogg/Opus is supported since
> > > 1.0.29, however that isn't currently added in this patch. And it may
> > > require libopus.
> > > And mp3 is supported at around version 1.1.0, but that version is in beta.
> > >
> > > This change focuses solely on updating to 1.0.31 and removing all
> > > backported patches.
> > >
> > > [1] https://libsndfile.github.io/libsndfile/formats.html
> >
> > Bah...
> >
> > No luck with V2 either.
> > This would require some patch to allow build without libopus support.
> > Since there is no libopus available, it will not include support for
> > libvorbis, libflac.
> > i.e. libsndfile will build, but will say:
> >
> > configure: WARNING: *** One or more of the external libraries (ie
> > libflac, libogg and
> > configure: WARNING: *** libvorbis) is either missing (possibly only
> > the development
> > configure: WARNING: *** headers) or is of an unsupported version.
> > configure: WARNING: ***
> > configure: WARNING: *** Unfortunately, for ease of maintenance, the
> > external libs
> > configure: WARNING: *** are an all or nothing affair.
> >
> >
> > Seems I forgot to check these extra configurations.
> >
> > Please disregard the V2 and apologies for the noise.
> >
> > I may try again with a V3, but let's see.
>
>
> Unfortunately we merged this as it passed the automated testing and there was 
> no
> other review feedback.

Oh.
Now I feel a bit worse.

>
> https://git.yoctoproject.org/poky/commit/?id=fd2c86b06963345683ac5dc4f47f9da8e0c8c69d
>
> It does make me worry about tests here and means we'll have to find some way 
> to
> fix this.

The silent nature of this build issue, suggests a few things to move forward:

1. Propose a patch upstream to cause a build failure if this
configuration isn't complete (i.e. all Xiph libs are enabled or not)
    It's their right to have this all Xiph libs or no Xiph libs support matrix.
2. For Yocto, we could add libopus, in the meantime OR
    Patch-out libopus in the build

There's also the option to revert this [now] and try again.

>
> Cheers,
>
> Richard
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162558): 
https://lists.openembedded.org/g/openembedded-core/message/162558
Mute This Topic: https://lists.openembedded.org/mt/89367260/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to