Thanks for the renaming, Saul. Some minor comments below. On Tue, Mar 8, 2022 at 1:33 AM Saul Wold <[email protected]> wrote: > > > - # If the recipe has been whitelisted we return empty lists > + # If the recipe has been skipped/ignored we return empty lists > if pn in d.getVar("CVE_CHECK_SKIP_RECIPE").split(): > - bb.note("Recipe has been whitelisted, skipping check") > + bb.note("Recipe has been skipped/ignored, skipping check") > return ([], [], [])
Wouldn't it be better with something like: "Recipe has been skipped by the cve-check" We then use the "skip" word when talking about the recipes only. A check for ignored CVEs is done below. > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass > index 270b7860c7..40eba73ce3 100644 > --- a/meta/classes/insane.bbclass > +++ b/meta/classes/insane.bbclass > @@ -441,7 +441,7 @@ def package_qa_hash_style(path, name, d, elf, messages): > QAPATHTEST[buildpaths] = "package_qa_check_buildpaths" > def package_qa_check_buildpaths(path, name, d, elf, messages): > """ > - Check for build paths inside target files and error if not found in the > whitelist > + Check for build paths inside target files and error if not paths are > allowed What about: Check for build paths inside target files and error if paths are not explicitly ignored I think this is what we want to say here? Marta
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#162875): https://lists.openembedded.org/g/openembedded-core/message/162875 Mute This Topic: https://lists.openembedded.org/mt/89627504/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
