On Wed, 2022-04-13 at 03:50 -0700, Abongwa Amahnui Bonalais wrote: > Okay thank you what about Using $(...) notation instead of legacy backticked > `...`. > base=`basename $0`, changing it to base=$(basename $0) > > Should I commence those changes? > I'm seeing that based om recommendations when I run shellcheck <name of file>
It depends on how you're testing the end result. I don't mind improving the scripts but what we don't really want are patches made by just doing what that tool says without the result being tested. How are you testing the results? Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#164319): https://lists.openembedded.org/g/openembedded-core/message/164319 Mute This Topic: https://lists.openembedded.org/mt/90437025/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
