Hi Stefan Firstly, thanks for the work extending and improving this.
Secondly, apologies for dredging this up, but I just found this looking back through the history for the release notes: On Friday, 8 October 2021 20:42:20 NZST Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier <[email protected]> > > Signed-off-by: Stefan Herbrechtsmeier > <[email protected]> --- > > (no changes since v1) > > scripts/lib/recipetool/create.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/lib/recipetool/create.py > b/scripts/lib/recipetool/create.py index 83cf25d9b7..893980a5ce 100644 > --- a/scripts/lib/recipetool/create.py > +++ b/scripts/lib/recipetool/create.py > @@ -1134,7 +1134,7 @@ def guess_license(srctree, d): > > return licenses > > -def split_pkg_licenses(licvalues, packages, outlines, > fallback_licenses=None, pn='${PN}'): +def split_pkg_licenses(licvalues, > packages, outlines, fallback_licenses=[], pn='${PN}'): """ > Given a list of (license, path, md5sum) as returned by guess_license(), > a dict of package name to path mappings, write out a set of Note that setting a mutable type (e.g. an empty list) as a default for a function parameter is not good practice in Python - see: https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/ I'm aware we have done this already in a few places - git grep "^def.*=\[\]" shows a few others that we probably ought to fix. Paul
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#164370): https://lists.openembedded.org/g/openembedded-core/message/164370 Mute This Topic: https://lists.openembedded.org/mt/86165224/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
