On Wed, Apr 20, 2022 at 9:32 AM Bruce Ashfield <[email protected]> wrote:
>
>
>
> On Wed, Apr 20, 2022 at 12:28 PM Russ Dill <[email protected]> wrote:
>>
>> do_kernel_configcheck utilizes pathnames relative to the sourcedir
>> but does not specify ${S} in [dirs]. tasks that do not specify
>> [dirs] default to the cwd of the bitbake parent process. This can be
>> seen by inspection of exec_func/exec_func_python of
>> bitbake/lib/bb/build.py or by placing a "print('CWD', os.getcwd())"
>> at the head of do_kernel_configcheck.
>>
>> This is problematic if bitbake is run from a directory that
>> contains a meta/ subdirectory. In this case the code:
>>
>> kmeta = d.getVar("KMETA") or "meta"
>> if not os.path.exists(kmeta):
>> kmeta = subprocess.check_output(['kgit', '--meta'],
>> cwd=d.getVar('S')).decode('utf-8').rstrip()
>>
>> Causes kmeta to be set to just "meta" if a meta directory exists
>> in the cwd of the bitbake parent process, or to the output of
>
>
> That isn't actually a problem, and is the design intent of that check. It
> allows a temporary/local override of the meta data, simply by creating a
> 'meta' subdir.
>
It's not working as intended though. While the check for the "meta"
path is done in the cwd of the bitbake parent process, the actual
usage of it is done in ${S}:
if analysis:
outfile = "{}/{}/cfg/invalid.txt".format(s,kmeta)
Which leads to:
DEBUG: Executing python function do_kernel_configcheck
ERROR: Error executing a python function in exec_func_python() autogenerated:
The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>
0001:
*** 0002:do_kernel_configcheck(d)
0003:
File: '/home/[USER]/[SRC-PATH]/build/../meta/classes/kernel-yocto.bbclass',
lineno: 591, function: do_kernel_configcheck
0587: if analysis:
0588: outfile = "{}/{}/cfg/invalid.txt".format(s,kmeta)
0589: if os.path.isfile(outfile):
0590: os.remove(outfile)
*** 0591: with open(outfile, 'w+') as f:
0592: f.write( analysis )
0593:
0594: if bsp_check_visibility and os.stat(outfile).st_size > 0:
0595: with open (outfile, "r") as myfile:
Exception: FileNotFoundError: [Errno 2] No such file or directory:
'[YOCTO-TMP-PATH]/work/[MACHINE]/[PN]/[PV]/git/meta/cfg/invalid.txt'
>
> Bruce
>
>
>>
>> kgit --meta if it does not.
>>
>> Signed-off-by: Russ Dill <[email protected]>
>> ---
>> meta/classes/kernel-yocto.bbclass | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/kernel-yocto.bbclass
>> b/meta/classes/kernel-yocto.bbclass
>> index 1d5a8cdf29..c787b2a122 100644
>> --- a/meta/classes/kernel-yocto.bbclass
>> +++ b/meta/classes/kernel-yocto.bbclass
>> @@ -620,6 +620,7 @@ python do_kernel_configcheck() {
>> if warnings_detected and kmeta_audit_werror:
>> bb.fatal( "configuration warnings detected, werror is set,
>> promoting to fatal" )
>> }
>> +do_kernel_configcheck[dirs] = "${S}"
>>
>> # Ensure that the branches (BSP and meta) are on the locations specified by
>> # their SRCREV values. If they are NOT on the right commits, the branches
>> --
>> 2.25.1
>>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at
> its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
--
Russ Dill
[email protected]
NIKOLA CORPORATION | nikolamotor.com
4141 E Broadway Rd | Phoenix | AZ | 85040
INFORMATION CONTAINED IN THIS E-MAIL TRANSMISSION IS CONFIDENTIAL. IF
YOU ARE NOT THE INTENDED RECIPIENT, DO NOT READ, DISTRIBUTE OR
REPRODUCE THIS TRANSMISSION (INCLUDING ANY ATTACHMENTS). IF YOU HAVE
RECEIVED THIS E-MAIL IN ERROR, PLEASE NOTIFY THE SENDER BY E-MAIL
REPLY AND THEN DELETE THIS E-MAIL.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164718):
https://lists.openembedded.org/g/openembedded-core/message/164718
Mute This Topic: https://lists.openembedded.org/mt/90587617/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
