David, It does seem like the line `do_image_complete[depends] = "virtual/kernel:do_create_spdx"` doesn't need to be hardcoded; I unfortunately don't remember why I added that. As a guess I would imagine it was so that you can add items that aren't normally part of an "image" (u-boot, kernel, etc.) to SPDX generation, in which case it should probably at least be a variable that can be overridden. It's also possible that line simply isn't useful at all since just creating the SPDX for those recipes doesn't mean they will be in the final SPDX generated tarball, and if they do we need some mechanism to specifically add them which would cover adding the dependencies also.
TL; DR It seems likely it can be removed. CC'd Saul Wold (who did most of the kernel SPDX generation) in case he knows something I don't On Thu, Apr 21, 2022 at 5:14 AM Davide Gardenal <[email protected]> wrote: > > Yes we could but I'm not sure if that dependency is needed in the first place. > Looking at the dependency graph I can see that other tasks depend upon it so > could it be redundant to have it? > > Davide > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#164760): https://lists.openembedded.org/g/openembedded-core/message/164760 Mute This Topic: https://lists.openembedded.org/mt/90602531/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
