Marcel, Peter,

On 5/31/22 23:32, Marcel Ziswiler wrote:
From: Peter Bergin <[email protected]>

In order to enable configuration option aaf (AVTP Audio Format)
used for AVB the library libavtp is a dependency but no recipe for
this library was present. aaf support for alsa-plugins was
introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.

Signed-off-by: Peter Bergin <[email protected]>
Signed-off-by: Marcel Ziswiler <[email protected]>

---
Resurrect from mailing list [1] as this is still not upstream.
End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World Conference in the TSN & Linux
track next month [2].

[1] 
https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_all_20210604090216.553285-2D1-2Dpeter-40berginkonsult.se_&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=j5mDhOeNcVWNco5eYp6S60KnL4GmuLwFOeDnKizzUfY4ScAsBe2IQUQckKzHOrVn&s=1nRYQeY7NOzqrW7qZafcgBMa2RIx8BtF-kVsHpEX-5c&e=
[2] 
https://urldefense.proofpoint.com/v2/url?u=https-3A__events.weka-2Dfachmedien.de_embedded-2Dworld-2Dconference_program_&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=j5mDhOeNcVWNco5eYp6S60KnL4GmuLwFOeDnKizzUfY4ScAsBe2IQUQckKzHOrVn&s=EnuuWrWZcXP5wNN4T2S7S57HMhsQNkAZRpv0q1iyMW8&e=

Changes in v3:
- Rename recipe to officially released PV of 0.2.0.
- Drop PROVIDES of avtp which just works around alsa-plugins refering to
   it as such instead of libavtp. Will update PACKAGECONFIG in
   alsa-plugins instead.

Changes in v2:
- Updated SRC_URI specifying mandatory protocol as https.
- Updated SRCREV to latest.

  meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
  create mode 100644 meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb

diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb 
b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb
new file mode 100644
index 0000000000..563debde3c
--- /dev/null
+++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb
@@ -0,0 +1,14 @@
+DESCRIPTION = "Open source implementation of Audio Video Transport Protocol 
(AVTP) \
+               specified in IEEE 1722-2016 spec."
+HOMEPAGE = 
"https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Avnu_libavtp&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=j5mDhOeNcVWNco5eYp6S60KnL4GmuLwFOeDnKizzUfY4ScAsBe2IQUQckKzHOrVn&s=CDG7OGmgTZNqph7uuR6Au6HBdZZmu_0lUYUC1dYWjsg&e=
 "
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
+
+SRC_URI = 
"git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1"

We don't have a single recipe with nobranch set in poky, so I think we should keep it this way. I assume this was needed because, there's no ${PV} branch available in the git repo (it's a tag).

Technically, ${PV} is a tag on github and not a branch. We don't have a single recipe with tag set in poky, so I think we also should keep it this way (tag= requires network to check that the tag hasn't moved between builds).

What I've seen some recipes do instead is to use github archives. See:
https://git.yoctoproject.org/poky/tree/meta/recipes-support/re2c/re2c_3.0.bb

Re: alsa-plugins which may require it in a PACKAGECONFIG option, it's not really a reason for inclusion if not enabled by default. Otherwise we would have one big layer only with all possible optional dependencies and their possible optional dependencies, etc...

Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#166363): 
https://lists.openembedded.org/g/openembedded-core/message/166363
Mute This Topic: https://lists.openembedded.org/mt/91462033/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to