Hi Luca,
your commit message is way better than mine.
One suggestion on your patch. I guess to be working on the target it
would be needed to add python3-pygment and python3-pyyaml as runtime
dependencies as well.
PACKAGECONFIG[optviewer] = ",-DPY_PYGMENTS_FOUND=OFF
-DPY_PYGMENTS_LEXERS_C_CPP_FOUND=OFF -DPY_YAML_FOUND=OFF,python3-pygments
python3-pyyaml,python3-pygments python3-pyyaml"
Markus
Am 22.06.22 um 22:44 schrieb Luca Ceresoli:
Hi Markus,
On Wed, 22 Jun 2022 19:32:50 +0200
"Markus Volk" <[email protected]> wrote:
Make it a PACKAGECONFIG option and thus avoid automagic to improve
reproducibility
Signed-off-by: Markus Volk <[email protected]>
---
meta/recipes-devtools/llvm/llvm_git.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-devtools/llvm/llvm_git.bb
b/meta/recipes-devtools/llvm/llvm_git.bb
index 67ed1eab00..b86605cbce 100644
--- a/meta/recipes-devtools/llvm/llvm_git.bb
+++ b/meta/recipes-devtools/llvm/llvm_git.bb
@@ -90,6 +90,9 @@ EXTRA_OECMAKE:append:class-nativesdk = "\
-DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \
"
+PACKAGECONFIG ?= ""
+PACKAGECONFIG[optviewer] = "-DPY_PYGMENTS_FOUND=ON
-DPY_PYGMENTS_LEXERS_C_CPP_FOUND=ON
-DPY_YAML_FOUND=ON,-DPY_PYGMENTS_FOUND=OFF,,python3-pygments python3-pyyaml"
+
I have been working on a different version of this patch earlier today
based on the discussion on this mailing list. Now it completed testing
on my machine and I have run a build on the autobuilders:
https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/1049
My approach was slightly different, but not dramatically. I wrote a
more informative commit message though. I'm sending my patch to have
both out so that we can find which is the best one.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#167258):
https://lists.openembedded.org/g/openembedded-core/message/167258
Mute This Topic: https://lists.openembedded.org/mt/91927018/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
